Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store.get() without parameters doesn't work #17

Closed
jardicc opened this issue Sep 2, 2018 · 5 comments
Closed

store.get() without parameters doesn't work #17

jardicc opened this issue Sep 2, 2018 · 5 comments

Comments

@jardicc
Copy link

jardicc commented Sep 2, 2018

store.get() without parameters doesn't work in version 3.0 but works in 1.0
In documentation is example without parameters.

@sant123
Copy link

sant123 commented Sep 14, 2018

Exactly, it throws this error:

assert.js:83
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: expected key to be a string

A workaround here is store.data. I think docs should be updated.

@dkebler
Copy link

dkebler commented May 1, 2019

@sant123 months later still a problem ...

either support should be put back in or docs updated although IMO it should be supported as was.

Dev has been silent. @jonschlinkert do you have time to do this? Accepting PRs?

@jonschlinkert
Copy link
Owner

jonschlinkert commented May 1, 2019 via email

@jardicc
Copy link
Author

jardicc commented May 1, 2019

I switched to the: https://www.npmjs.com/package/preferences This is really great module. Once you assign value then it saved by default and it looks like just like JS object. I believe it uses setters.

@jonschlinkert
Copy link
Owner

fixed by #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants