Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript] fix GrayMatterOption.engines type #74

Conversation

stas-vilchik
Copy link
Contributor

The current definition of GrayMatterOption.engines is not correct. string and object in this snippet are not types, but the parameter names. Their type is resolved as any.

engines?: {
  [index: string]:
    | ((string) => object)
    | { parse: (string) => object; stringify?: (object) => string }
}

The problem is that the TypeScript requires to always put parameter names.

@stas-vilchik stas-vilchik changed the title [typescrip]t fix GrayMatterOption.engines type [typescript] fix GrayMatterOption.engines type Apr 27, 2018
@mysticflute
Copy link

any idea on when this can be pulled in?

@jaredwray
Copy link

jaredwray commented Jun 21, 2018

I believe this is the same issue I am seeing. Parameter 'string' implicitly has an 'any' type. @jonschlinkert can we get this pulled in? Anyway we can help on this?

@Himenon
Copy link

Himenon commented Nov 18, 2018

I have the same problem.

@tstelzer
Copy link

Same here, please merge.

@EryouHao
Copy link

@jonschlinkert please merge, thanks.

@1999
Copy link

1999 commented Jan 7, 2019

@jonschlinkert hey, this PR is more than half a year old and it's pretty much important for all TS users. Also, the project hasn't got any changes during the last half-year. What's the status of gray-matter project?

@robertmassaioli
Copy link
Collaborator

This change looks good to me. It has also been reported four times:

I'm going to merge it in and do a release when I gain release permission.

Also, hello everybody, I'm a new Contributor on a trial run and, if this goes well, I'll be looking to help make that Pull Requests are at-least initially reviewed within a 2-week period by a contributor to this repository and then are given the next steps to getting the PR merged in.

I am especially keen to see bugfixes be merged in and released.

I don't yet have access to release but, hopefully, will be able to do so soon. Cheers.

@robertmassaioli robertmassaioli merged commit 59122ca into jonschlinkert:master Jan 10, 2019
This was referenced Jan 10, 2019
@robertmassaioli robertmassaioli added the bug A problem that causes an error in the library at compilation or runtime. label Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A problem that causes an error in the library at compilation or runtime.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants