Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update html-minifier version #49

Merged
merged 1 commit into from
Mar 22, 2016
Merged

update html-minifier version #49

merged 1 commit into from
Mar 22, 2016

Conversation

igoradamenko
Copy link
Contributor

#48

@jonschlinkert
Copy link
Owner

thanks!

jonschlinkert added a commit that referenced this pull request Mar 22, 2016
update html-minifier version
@jonschlinkert jonschlinkert merged commit b64998a into jonschlinkert:master Mar 22, 2016
@jonschlinkert
Copy link
Owner

want to update unit tests too? otherwise I'll have to do it when I get a chance. fwiw I think this bump shouldn't be necessary anyway, npm should still install html-minifies 1.3.0 since it falls in the range of ^1.0.0

@igoradamenko
Copy link
Contributor Author

It looks strange, but an hour ago npm installed wrong version of html-minifier.

Anyway, I can update tests too. Should I just add my case to fixtures & expected files or create new fixture for that?

@jonschlinkert
Copy link
Owner

Should I just add my case to fixtures & expected files or create new fixture for that?

Sorry, I should have clarified, the tests might not need to be updated. But I know from past experience that (at minimum) when changes are made in html-minifier there are usually minute changes that need to be made in our fixtures. if the tests are passing still then no need to update anything.

thanks

shinnn pushed a commit that referenced this pull request Mar 23, 2016
@igoradamenko
Copy link
Contributor Author

@jonschlinkert Just for restoring a justice: errors were in html-minifier and your package worked good. I've fixed & wrote test for them in this PR: kangax/html-minifier#583 and v.1.3.2 will work fine.

So, you was right about:

this bump shouldn't be necessary

Sorry about the confusion and thanks for your patience! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants