Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Number (objects) #24

Closed

Conversation

omrilotan
Copy link

Address issue #18

The check is not very expensive

# all
v6.2:
v6.1 x 234,123 ops/sec ±4.36% (79 runs sampled)
fastest is 'v6.1'

# string
v6.2:
v6.1 x 1,957,712 ops/sec ±8.42% (70 runs sampled)
fastest is 'v6.1'

# number
v6.2:
v6.1 x 2,165,615 ops/sec ±6.08% (75 runs sampled)
fastest is 'v6.1'

@jonschlinkert
Copy link
Owner

I appreciate the PR but will have to decline. Using new Number() isn't a good practice, and I've never actually seen it used in code. Thanks, and please feel free to do another PR anytime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants