Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update benchmarked to latest and related changes, add one more benchmark #5

Closed
wants to merge 1 commit into from

Conversation

tunnckoCore
Copy link
Contributor

ref #4

If that added benchmark case is okey, we can make it current?

@jonschlinkert
Copy link
Owner

we can make it current?

make what current?

@jonschlinkert
Copy link
Owner

If you mean, remove kind-of and use the code in your pr, no. Why would we create more complexity in this module when that code is already well unit-tested and optimized in kind-of? kind-of is a very small and optimized library. Any extremely small optimizations we might by moving code from kind-of to this library are outweighed by the benefits of the module pattern in this case. Normally I might consider it more, but given how much both modules are downloaded, I'm not inclined to make gratuitous changes.

Repository owner locked and limited conversation to collaborators Sep 1, 2016
@jonschlinkert
Copy link
Owner

Please read the updated message on #4. Clearly no one is comprehending that the size issue was resolved 1 1/2 years ago. I'm not sure how to make this more obvious.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants