change option name from ocd to extra #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using ocd as an option name to turn on extra rules around whitespace etc is not very inclusive
|
First, I'd like to say thank you for the pull request. It's much appreciated, and I'd like to merge the changes that make improvements to the code.
Note the "About" section on the repository:
Jake, this project is based on my preferences and I have OCD. Are you suggesting that I drop mention of OCD to be more "inclusive" of "normal" people? |
No, to be more inclusive in general. I would prefer to not have code which uses a mental health condition as the name of a configuration option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using ocd as an option name to turn on extra rules around whitespace etc is not very inclusive