fix basename of cwd as default fallback behaviour #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jonschlinkert, could you take a look at this PR? thanks! |
kefranabg
approved these changes
Jun 15, 2019
|
Hi @jonschlinkert, thanks for your work ! I really need this fix too 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Handy package. Been using it for a while. Thanks for refactoring the code recently. 😀
It looks like a breaking change was introduced and is now inconsistent with the README description.
When passing no
cwdargument, inside a directory withoutpackage.jsonnor Git repo, an error is thrown bypath.basename(undefined).This patch implements as per documentation and adds a test.