fixed tag stripping... #1
Conversation
|
Do you remember which test was failing? I'm assuming the one that was updated. Perhaps there was an API change in cheerio? or the arguments were passed incorrectly? I'm not sure I like the idea of using regex to do this since cheerio ought to handle it. If cheerio isn't doing what's expected, it seems like we should create an issue there, rather than monkey-patching this code. thoughts? |
|
ah! my favorite stackoverflow article! I guess we should create an issue on the cheerio repo, and I'll use the patchworked code in the meanwhile at work. I think what the article was targeting was more so finding the text in between tags and wholly parsing html, because that would require lookbehinds, etc. for something as simple as removing tags wholly including the text inside of the tags, it seems that regex works very well... |
yeah I was just going for a bit of humor lol. which tags weren't working for you? all of them, or just specific ones? |
@RamanjitKhakh was parsing some html, and some tags were not getting deleted! This fixes a test case, and a solution we came up with that also make sure that all tags are deleted..