Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade has-value #4

Merged
merged 1 commit into from Dec 11, 2018
Merged

Upgrade has-value #4

merged 1 commit into from Dec 11, 2018

Conversation

TrySound
Copy link
Contributor

Micromatch is quite big because of duplicated dependecies. This will
allow to reduce amount of packages in micromatch.

Micromatch is quite big because of duplicated dependecies. This will
allow to reduce amount of packages in micromatch.
@jonschlinkert
Copy link
Owner

thank you!

@jonschlinkert jonschlinkert merged commit bc65b7b into jonschlinkert:master Dec 11, 2018
@TrySound
Copy link
Contributor Author

By the way yarn has a great yarn upgrade-interactive --latest utility which allows to upgrade dependencies just fine.

@TrySound TrySound deleted the upgrade-has-value branch December 11, 2018 20:20
@TrySound
Copy link
Contributor Author

But it requires yarn.lock

@TrySound
Copy link
Contributor Author

Did you tried yarn?

@jonschlinkert
Copy link
Owner

By the way yarn has a great yarn upgrade-interactive --latest utility which allows to upgrade dependencies just fine.

I'm guessing it doesn't run on different node.js versions to ensure there are no breaking changes? This PR will require a major bump because of ES6 syntax in deps, just FYI.

@jonschlinkert
Copy link
Owner

Also I haven't used manual tools like yarn for this in a while. I use automation.

@TrySound
Copy link
Contributor Author

But travis checks, right?
Which automation are you talking about? Can you just update all your packages and make micromatch a few times smaller?

@jonschlinkert
Copy link
Owner

Btw, I'm getting ready to publish the next version of micromatch, which only has two deps: picomatch (which has no deps) and braces (which is also being refactored to reduce deps)

@TrySound
Copy link
Contributor Author

Nice!

@jonschlinkert
Copy link
Owner

jonschlinkert commented Dec 11, 2018

Can you just update all your packages and make micromatch a few times smaller?

Lol, micromatch was smaller when it was published, and upgrading packages (like this PR) is exactly what made micromatch bigger, because it caused version mismatches.

But travis checks, right?

I use a local CLI, and trevor.

@TrySound
Copy link
Contributor Author

Cool, I already like picomatch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants