+ Add support for Laravel 5.8 #56
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This package is usually the only one stopping me from upgrading and so far there has never been an issue when testing it with a new Laravel version. My temporary fix is to fork it, add the new Laravel version and use that until this package here gets updated. My suggestion would be to just use |
|
+1 Please. This prevents anybody to upgrade to Laravel 5.8 |
|
Can you perhaps fix this to just make the suggested change of version > 5.2 ? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new year, a new Laravel version! This should do the trick, as nothing major has changed. Tests pass, so hopefully there aren't any problems merging this.
@bostanio Would be great if you had time to merge this ASAP, this is the only thing keeping me from upgrading :) Thanks in advance!