Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UrlResolverImpl should work with context = null #1990

Closed
imeszaros opened this issue Sep 14, 2020 · 0 comments · Fixed by #1996
Closed

UrlResolverImpl should work with context = null #1990

imeszaros opened this issue Sep 14, 2020 · 0 comments · Fixed by #1996

Comments

@imeszaros
Copy link
Member

Pac4j's SAML2Client does a weird thing at initialization which will cause an NPE to be thrown because jooby-pac4j's UrlResolverImpl is not prepared for the case that the argument context can be null.

I have not the slightest idea why is it like this but I could only overcome this issue by plugging in a custom implementation of UrlResolver that itself builds the full URL purely from the applications Config instead of using the context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant