Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests contains two fixes when generating the openapi defintion using jooby-openapi:
Fix for Map:
According to https://swagger.io/docs/specification/data-models/dictionaries/ a map should be represented by a schema that has the type as well as an additionalProperties element with the type property set to the value property of the map.
So the following map
should become the following schema:
Fix for byte[]:
There exists a special ByteArraySchema class that can be used in this case, as it produces the correct schema for it: