Fix avaje module #3426
Merged
Fix avaje module #3426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknack
reviewed
May 18, 2024
| @@ -68,7 +66,7 @@ public void install(Jooby application) throws Exception { | |||
| e -> { | |||
| final var key = e.getKey(); | |||
| if (key.getName() == null) { | |||
| beanScope.provideDefault(key.getType(), e::getValue); | |||
| beanScope.provideDefault(key.getType(), e.getValue()::get); | |||
jknack
reviewed
May 18, 2024
|
|
||
| @Singleton | ||
| @Path("") | ||
| @InjectModule(requires = {JsonMapper.class, Config.class, String.class}) |
There was a problem hiding this comment.
never use Avaje Inject. Why do we need this line?
There was a problem hiding this comment.
In Avaje Inject, the dependency graph is typically validated when the application compiles. As beans provided by Jooby Modules are registered at runtime, you must add @InjectModules(requires={String.class, <other Jooby Module Provided Bean ClassNames>…}) to inform the avaje processor that these beans are provided at runtime.
from https://jooby.io/#dependency-injection-avaje-inject-mvc-routes :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jknack
AvajeInjectModule seems doesn't work as expected, at least for me.
With a very basic example (reproduced in test c9c81fd) Jooby inner services injection fails with class cast exception, for example
JsonMapper:I assume this is due to the fact that services already wrapped into lambda in
singletone()jooby/jooby/src/main/java/io/jooby/internal/ServiceRegistryImpl.java
Line 61 in 03bb587
Hence, the default binding need to be changed to
beanScope.provideDefault(key.getType(), e.getValue()::get);Also,
Configbinding was removed as it is already in service registry