Use absolute domain name in message #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we tell the user which CNAME record to add, make the entry absolute by ending it with a dot. This prevents that the user accidentally adds a record for _acme-challenge.example.org.example.org when they copy-paste.
|
What's the hold up with getting this merged? This is definitely a snag that anyone using bind9 will run into (I know I did). |
|
Perhaps active development has shifted to https://github.com/acme-dns/acme-dns-client? It's what I use now anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we tell the user which CNAME record to add, make the entry absolute
by ending it with a dot. This prevents that the user accidentally adds a
record for _acme-challenge.example.org.example.org when they copy-paste.