Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make installation instructions more comprehensive #64

Merged
merged 5 commits into from
Apr 8, 2018

Conversation

Daniel15
Copy link
Contributor

It was pretty tricky to work out what to do... Hopefully these instructions help someone. Feel free to modify or rewrite anything I've written if you don't like it 😃

@coveralls
Copy link

coveralls commented Mar 19, 2018

Coverage Status

Coverage remained the same at 92.244% when pulling 0991b3e on Daniel15:patch-2 into 7b2203c on joohoi:master.

Copy link
Owner

@joohoi joohoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think this is really valuable information for the users. However I feel that while the step 6 (adding NS and A recods) should be added to the installation instructions, the other points should probably be placed under a new title of Troubleshooting for clarity.

README.md Outdated

9) Call the `/register` API endpoint to register a test domain:
```
$ curl -X POST -d "{}" http://auth.example.com/register
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data for register endpoint can be left out if no whitelisting is needed.

README.md Outdated
In all the commands listed below:
- `example.com` is your domain name
- `auth.example.com` is the subdomain you want to use for acme-dns
- `198.51.100.1` is the **public** IP address of the system running acme-dns
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that in examples it would be better to use address in a private address space defined by RFC 1918

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

198.51.100.1 is actually a reserved IP address for documentation purposes: https://tools.ietf.org/html/rfc5737

I'm in favor of keeping it, rather than using a private address.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, @Daniel15 cleared that up in the comment, and I learned something. I'm in favor of keeping this as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, didn't see that.

README.md Outdated
{"username":"eabcdb41-d89f-4580-826f-3e62e9755ef2","password":"pbAXVjlIOE01xbut7YnAbkhMQIkcwoHO0ek2j4Q0","fulldomain":"d420c923-bbd7-4056-ab64-c3ca54c9b3cf.auth.example.com","subdomain":"d420c923-bbd7-4056-ab64-c3ca54c9b3cf","allowfrom":[]}
```

10) Call the `/update` API endpoint to set a test TXT record:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be useful to underline that the TXT content needs to be exactly 43 characters long. That's a common source of confusion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to this. I tried setting a test value to make sure everything worked before hitting the LetsEncrypt API

    --data '{"subdomain": "foo", "txt": "bar"}'

It took me a few tries and diving into source to understand why that failed.

@Daniel15
Copy link
Contributor Author

Daniel15 commented Mar 19, 2018 via email

@joohoi
Copy link
Owner

joohoi commented Mar 19, 2018

198.51.100.0/24 is explicitly reserved for use in documentation (RFC 5737)

Awesome! That's completely fine in this case. TIL :)

- Move DNS config to separate "DNS Records" section
- Move testing to separate "Testing It Out" section
@Daniel15
Copy link
Contributor Author

@joohoi I moved some stuff around, let me know what you think of it now :)

@jvanasco
Copy link
Contributor

A lot of people turn off DNS on their firewall (e.g. iptables, ufw, etc )

I think it would be a good addition to remind people to ensure port 53 is open.

@joohoi
Copy link
Owner

joohoi commented Apr 8, 2018

LGTM! merging

@joohoi joohoi merged commit dd12fa7 into joohoi:master Apr 8, 2018
@Daniel15 Daniel15 deleted the patch-2 branch April 25, 2018 09:16
@gregwkeller
Copy link

Consider updating the systemd section to include this step:

"As of systemd 232 (released in 2017) you can edit /etc/systemd/resolved.conf and add this line:

DNSStubListener=no"

Otherwise the Stub Listener blocks ACME-DNS

jacobmyers-codeninja pushed a commit to jacobmyers-codeninja/acme-dns that referenced this pull request Sep 30, 2020
Make installation instructions more comprehensive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants