Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Add Lego to supported clients #94

Merged
merged 2 commits into from
Jul 9, 2018

Conversation

cpu
Copy link
Contributor

@cpu cpu commented Jul 9, 2018

The Lego ACME client/library supports ACME-DNS as of go-acme/lego@04e2d74 馃帀

@coveralls
Copy link

coveralls commented Jul 9, 2018

Coverage Status

Coverage remained the same at 92.244% when pulling 247a38c on cpu:cpu-add-lego-client into 52e977c on joohoi:master.

@joohoi
Copy link
Owner

joohoi commented Jul 9, 2018

That's awesome news! Thanks for writing the Lego acme-dns provider!

For this PR: I would prefer alphabetical order for the client entries, could you make that change?

@cpu
Copy link
Contributor Author

cpu commented Jul 9, 2018

That's awesome news! Thanks for writing the Lego acme-dns provider!

@joohoi NP! For what its worth I switched all of my personal infrastructure over to using Lego + ACME-DNS the other day. Worked great :-) Its nice to be using ACME v2 and wildcard certificates for my own servers finally. Thanks again for the excellent project.

For this PR: I would prefer alphabetical order for the client entries, could you make that change?

Sure thing, fixed in 247a38c

@joohoi
Copy link
Owner

joohoi commented Jul 9, 2018

Sounds good! I wonder if Lego gives dns providers access to the account details. I have been sketching out a plan to suggest users to add CAA record including ACME CAA extensions, namely the accounturi in order to make it safe to use third party acme-dns instance.

I'm planning to host a public instance at some point when the ACME CAA extensions are turned on in Let's Encrypt production.

@joohoi joohoi merged commit 8aa869b into joohoi:master Jul 9, 2018
@cpu cpu deleted the cpu-add-lego-client branch July 10, 2018 12:39
@cpu
Copy link
Contributor Author

cpu commented Jul 10, 2018

I wonder if Lego gives dns providers access to the account details. I have been sketching out a plan to suggest users to add CAA record including ACME CAA extensions, namely the accounturi in order to make it safe to use third party acme-dns instance.

The Lego acme.ChallengeProvider interface is quite minimal and doesn't pass anything to the provider except the domain in question, the challenge token, and a key authorization string:
https://github.com/xenolf/lego/blob/04e2d74406d42a3727e7a132c1a39735ac527f51/acme/provider.go#L5-L12

Its probably doable but I think maybe handling it at the challenge provider level vs as part of the broader client challenge solving process might be a mismatch.

@joohoi
Copy link
Owner

joohoi commented Jul 10, 2018

Thanks for the info! It's exactly the same thing with Certbot hooks. It might be easier to just document around it and tell users where to find the account information then.

@Ajedi32
Copy link
Contributor

Ajedi32 commented Jul 10, 2018

I wonder if Lego gives dns providers access to the account details. I have been sketching out a plan to suggest users to add CAA record including ACME CAA extensions, namely the accounturi in order to make it safe to use third party acme-dns instance.

FWIW, this is a really cool idea.

But why would the provider need access to the account details? Doesn't registering a new domain with acme-dns require manually adding CNAME records to the host CA anyway? That's the step where the CAA record would be added, right? If you're serving the CAA records with acme-dns that doesn't really make it safe to use a third-party instance since a malicious acme-dns server could just alter the CAA record whenever it wants to misbehave.

@joohoi
Copy link
Owner

joohoi commented Jul 10, 2018

The idea is to instruct the user to add the correct CAA record to their main zone, as that's where it should be requested from (read: non-acme-dns). To print it out for the user with the CNAME records to add would be great for the UX, but looks like it would involve hopping through quite a few hoops.

@Ajedi32
Copy link
Contributor

Ajedi32 commented Jul 10, 2018

Ah, yeah I see. Yes, it would certainly be nice if the CLI could tell you exactly what CAA record to add.

jacobmyers-codeninja pushed a commit to jacobmyers-codeninja/acme-dns that referenced this pull request Sep 30, 2020
* README: Add Lego to supported clients

* README: List clients in alpha sort
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants