Fixed multiple IDs bug

from w3c validator
joomdev · Jul 7, 2021 · 7751880 · 7751880
1 parent 8cea18e
commit 7751880
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 14 deletions.
diff --git a/layouts/fields/checkbox.php b/layouts/fields/checkbox.php
@@ -10,7 +10,7 @@
 extract($displayData);
 $options = ModJDSimpleContactFormHelper::getOptions($field->options);
 $attrs = [];
-$attrs[] = 'id="' . $field->id . '"';
+$attrs[] = 'id="' . $field->name . '-' . $module->id .'"';
 if ($field->required) {
     $attrs[] = 'required';
     if (isset($field->custom_error) && !empty(trim($field->custom_error))) {
@@ -21,8 +21,8 @@
 }
 ?>
 <div class="form-check form-check-inline">
-   <input class="form-check-input" type="checkbox" name="jdscf[<?php echo $field->name; ?>][cb]" value="1" id="<?php echo $field->name; ?>" <?php echo implode(' ', $attrs); ?> />
-   <label class="form-check-label" for="<?php echo $field->name; ?>">
+   <input class="form-check-input" type="checkbox" name="jdscf[<?php echo $field->name; ?>][cb]" value="1" <?php echo implode(' ', $attrs); ?> />
+   <label class="form-check-label" for="<?php echo $field->name; ?>-<?php echo $module->id; ?>">
       <?php echo $label; ?>
    </label>
 </div>
diff --git a/layouts/fields/file.php b/layouts/fields/file.php
@@ -9,17 +9,17 @@
 defined('_JEXEC') or die;
 extract($displayData);
 $attrs = [];
-$attrs[] = 'id="' . $field->id . '"';
+$attrs[] = 'id="' . $field->name . '-' . $module->id . '"';
 if ($field->required) {
-    $attrs[] = 'required';
-    if (isset($field->custom_error) && !empty(trim($field->custom_error))) {
-       $attrs[] = 'data-parsley-required-message="' . JText::sprintf($field->custom_error) . '"';
-    } else {
-       $attrs[] = 'data-parsley-required-message="' . JText::sprintf('MOD_JDSCF_REQUIRED_ERROR', strip_tags($label)) . '"';
-    }
- }
-$attrs[] = 'id="' . $field->name . '-file-input"';
-//fetching allowed types
+   $attrs[] = 'required';
+   if (isset($field->custom_error) && !empty(trim($field->custom_error))) {
+      $attrs[] = 'data-parsley-required-message="' . JText::sprintf($field->custom_error) . '"';
+   } else {
+      $attrs[] = 'data-parsley-required-message="' . JText::sprintf('MOD_JDSCF_REQUIRED_ERROR', strip_tags($label)) . '"';
+   }
+}
+
+// fetching allowed types
 $params = JComponentHelper::getParams('com_media');
 $allowable = array_map('trim', explode(',', $params->get('upload_extensions')));
 $allowedMaxSize = $params->get('upload_maxsize');
@@ -34,7 +34,7 @@
 $document->addStyleDeclaration($style);
 ?>
 <div class="custom-file">
-   <input id="<?php echo $field->name; ?>-<?php echo $module->id; ?>" accept="<?php echo '.' . implode( ',.', $allowable ); ?>" type="file" name="jdscf[<?php echo $field->name; ?>]" class="custom-file-input" <?php echo implode(' ', $attrs); ?>>
+   <input accept="<?php echo '.' . implode( ',.', $allowable ); ?>" type="file" name="jdscf[<?php echo $field->name; ?>]" class="custom-file-input" <?php echo implode(' ', $attrs); ?>>
    <label class="custom-file-label" for="<?php echo $field->name; ?>-<?php echo $module->id; ?>"><?php echo JText::_('MOD_JDSCF_FILE_LBL'); ?></label>
 </div>