Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsaved changes - warn the user #62

Open
shoulders opened this issue Jul 10, 2019 · 3 comments
Open

unsaved changes - warn the user #62

shoulders opened this issue Jul 10, 2019 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@shoulders
Copy link

when editing the template sometimes users can exit without saving.

When you currently exit the 'template options' there is no warning to say there are unsaved changes. Can this be added?

Reason: some people might edit their whole template in one setting or completely redue the layout and then click the wrong button loosing all their work.

@shoulders shoulders changed the title if changes have been made and not saved - warn the user unsaved changes - warn the user Jul 10, 2019
@chetanmadaan
Copy link
Member

I completely agree... Currently there is a Javascript alert that comes up if you try to close the window without savings. Let me see if we can do something similar where it's upon clicking the exit button too and also have some sort of indicator at the save button that shows that there are pending changes to be saved.

Thanks,
Chetan

@chetanmadaan chetanmadaan self-assigned this Jul 10, 2019
@chetanmadaan chetanmadaan added the enhancement New feature or request label Jul 10, 2019
@chetanmadaan
Copy link
Member

The problem seems to be that the Layout Manager changes aren't considered unsaved. So you can even close the window and it won't prompt you for saving the changes.

Any other changes work fine on closing the window and trying to click the close button as well.

@chetanmadaan chetanmadaan added the bug Something isn't working label Jul 10, 2019
@shoulders
Copy link
Author

shoulders commented Jul 10, 2019

I can confirm that you are right. It is in the layout editor changes are not considered. perhaps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants