Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for XMLINFO rules #120

Merged
merged 13 commits into from
Jun 29, 2021
Merged

Updates for XMLINFO rules #120

merged 13 commits into from
Jun 29, 2021

Conversation

dryabov
Copy link
Collaborator

@dryabov dryabov commented May 11, 2021

  • check all reserved words;
  • allow trailing "for Joomla" in the listing name;
  • error for non-ASCII characters in the listing name;
  • check length of the listing name (warning for 40+, error for 80+);
  • code refactoring: loading of extension's language file is extracted into loadExtensionLanguage function.

@dryabov
Copy link
Collaborator Author

dryabov commented May 12, 2021

Ref. Issue #110

@dryabov
Apply naming rules to the main manifest file(s?) only (others are che…
c50e39e 
…cked for URLs, ASCII, length, and menu name only)
@dryabov
Copy link
Collaborator Author

dryabov commented May 17, 2021

Naming-related checks are limited to the top-level manifest file only.

@dryabov dryabov mentioned this pull request Jun 26, 2021
Closed
@dryabov dryabov mentioned this pull request Jun 26, 2021
Merged
@Llewellynvdm Llewellynvdm linked an issue Jun 29, 2021 that may be closed by this pull request
Extension Names - Listing Validation #110
Closed
@Llewellynvdm Llewellynvdm merged commit 055a9b1 into joomla-extensions:develop Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extension Names - Listing Validation
2 participants
@dryabov @Llewellynvdm