Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validation of XML manifests #204

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

dryabov
Copy link
Collaborator

@dryabov dryabov commented Jul 27, 2023

Fixes issue #202 and adds few more checks for XML manifests:

  • check that plugin manifest contains 'plugin' attribute in <files> children;
  • check that module manifest contains either <element> tag or 'module' attribute in <files> children;
  • check for required 'id' and 'type' attributes for package's <files> children;
  • check that <files> node is not empty.

@dryabov dryabov merged commit 0c41b95 into joomla-extensions:develop Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant