Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use InnoDB and utf8mb4_unicode_ci in the patchtester too #127

Merged
merged 3 commits into from Mar 2, 2016
Merged

Use InnoDB and utf8mb4_unicode_ci in the patchtester too #127

merged 3 commits into from Mar 2, 2016

Conversation

andrepereiradasilva
Copy link

Summary of Changes

Create patchtester tables with InnoDB and utf8mb4_unicode_ci.

Testing Instructions

  1. Install patchtester beta 4 with this patch integrated on a joomla latest staging (clean install).
    com_patchtester-beta-4-ut8mb4.zip
  2. Check if everything is working fine.

Observations

To not cause issues added a drop to existing tables first.
Not an expert in databases, so please check if anything more is needed.

To not cause issues putted a select to drop the tables first.
Not an expert on db, so please check if anything more is needed.
@mbabker
Copy link

mbabker commented Mar 2, 2016

Two things:

  1. The DROP TABLE query isn't needed. Updates between the beta tagged releases aren't fully supported right now, similar to the core CMS (that'll change after a stable tag, it's mostly because I didn't do SQL deltas as needed for other database changes).

  2. The install script should now check for 3.5.0 as the minimum instead of 3.3.0 if we're going to add the utf8mb4 stuff, that's checked here.

@andrepereiradasilva
Copy link
Author

done and done

mbabker added a commit that referenced this pull request Mar 2, 2016
Use InnoDB and utf8mb4_unicode_ci in the patchtester too
@mbabker mbabker merged commit 7b9f5fd into joomla-extensions:master Mar 2, 2016
@andrepereiradasilva andrepereiradasilva deleted the patch-1 branch March 5, 2016 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants