Skip to content

Commit

Permalink
Add 4.3.0 release
Browse files Browse the repository at this point in the history
  • Loading branch information
@joomdonation
joomdonation committed Oct 23, 2023
1 parent 7546a48 commit e6a8f3d
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions manifest.xml
View file
Expand Up @@ -41,4 +41,18 @@
<sha512>8e6ac146d9bf907971a25728f4ed6cfad900ab51d1bf33a157f11b42bfcb8b7dfbc6c21c9eeebfe2cf572220db33f73fa29807f3d350220ed4e73b09866dcdad</sha512>
<targetplatform name="joomla" version="((4\.[01234])|(5\.0))" />
</update>
<update>
<name>Weblinks Extension Package</name>
<description>Joomla! CMS Weblinks Package</description>
<element>pkg_weblinks</element>
<type>package</type>
<version>4.3.0</version>
<client>site</client>
<infourl title="Weblinks Extension Package">https://github.com/joomla-extensions/weblinks/releases/tag/4.3.0</infourl>
<downloads>
<downloadurl type="full" format="zip">https://downloads.joomla.org/extensions/weblinks/4-3-0/pkg-weblinks-4-3-0-zip?format=zip</downloadurl>
</downloads>
<sha512>7da491eee68c2f98549692b2028c47096fbbdd23c5105ddd8df3631c3e66a555c205b9af97bbd5acb3ebb0e6fb7b1aef55f5bf83ab2e25a402b2e807834c0460</sha512>
<targetplatform name="joomla" version="((4\.[34])|(5\.[01234]))" />
</update>
</updates>

13 comments on commit e6a8f3d

@jochenpa
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this is the wrong filename I think. It is -zip, but I think it should be .zip ...

@joomdonation
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jochenpa The link is generated by the extension which we are using to manage downloads. You can go here https://downloads.joomla.org/extensions/weblinks/4-3-0 to check the link from Download button, it is correct.

@jochenpa
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah OK, I hoped I found the problem.
So - Joomla is reporting it could not unpack the file: "Datei konnte nicht entpackt werden: pkg-weblinks-4-3-0-zip_format_zip"
The file was downloaded successfully, it is in the tmp directory ...

@jochenpa
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Joomla is expecting a file with ".zip" at the end?
If i manually download the file it has the .zip extension ...
But I don't knew - I just want to inform you there is a Problem. :-)

@joomdonation
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. So how did you install the package? Could you please download the package manually at https://downloads.joomla.org/extensions/weblinks/4-3-0 and try to install to see if you got the same error?

@joomdonation
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jochenpa So I updated the download link. I tried to update from my local Joomla installation and it worked. Could you please help trying again?

@jochenpa
Copy link

@jochenpa jochenpa commented on e6a8f3d Oct 23, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi.
The Update gets a step further. Now I have the same problem as here: "Installation failed #539"
Joomla\Filesystem\File::delete: Failed deleting inaccessible file weblinks.php
Paket Update: Bei der Installation der Erweiterung trat ein Fehler auf: plg_finder_weblinks.zip
I would be able to delete that file per hand, but others might not.
Should I wait for an update from your site or fix it myself by deleting that file? (weblinks.php)

@jochenpa
Copy link

@jochenpa jochenpa commented on e6a8f3d Oct 23, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 2 weblinks.php files:
administrator/components/com_weblinks/helpers/weblinks.php
Content shows

<?php

/**
 * @package     Joomla.Administrator
 * @subpackage  Weblinks
 *
 * @copyright   Copyright (C) 2005 - 2017 Open Source Matters, Inc. All rights reserved.
 * @license     GNU General Public License version 2 or later; see LICENSE.txt
 */

// phpcs:disable PSR1.Files.SideEffects
\defined('_JEXEC') or die;
// phpcs:enable PSR1.Files.SideEffects

/**
 * Weblinks helper.
 *
 * @since  1.6
 */
class WeblinksHelper extends \Joomla\Component\Weblinks\Administrator\Helper\WeblinksHelper
{
}

The other is this:
plugins/system/weblinks/weblinks.php
Content shows
/**
* Database Driver Instance
*
* @var \Joomla\Database\DatabaseDriver
* @SInCE 4.0.0
*/

@joomdonation
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like there was a typo, but I'm unsure if that's the reason causing the error Joomla\Filesystem\File::delete: Failed deleting inaccessible file weblinks.php . Could you please help updating this attached package manually to see if the error still happens ?

pkg-weblinks-4.3.0.zip

@jochenpa
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, still the same:
Joomla\Filesystem\File::delete: Failed deleting inaccessible file weblinks.php

@jochenpa
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second file "plugins/system/weblinks/weblinks.php" has vanished.

@joomdonation
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If so, I'm afraid of you might have to try to use the workaround I documented here https://membershipprodoc.joomservices.com/troubleshooting/fix-error-deleting-inaccessible-file . As mentioned somewhere, I just copied the solution from the original Joomla discussion about the issue joomla/joomla-cms#23504

@jochenpa
Copy link

@jochenpa jochenpa commented on e6a8f3d Oct 23, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workaround does not help/work.

Please sign in to comment.