Add environments for different resolutions #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therunnergit
force-pushed
the
different-window-sizes
branch
from
0252040
to
a921b94
Compare
|
Works as described on a Windows machine. Please one more test on another machine. Thank you @therunnergit! |
therunnergit
force-pushed
the
different-window-sizes
branch
from
a921b94
to
e130b23
Compare
therunnergit
force-pushed
the
different-window-sizes
branch
from
e130b23
to
8fd6f1d
Compare
|
closing for #164 |
|
works:
this is part of #143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional optional parameter to run tests in different environments, and provides 3 new environments with different screen resolutions.
How to test
Execute the following commands:
vendor/bin/robo run:tests: will run the default desktop testvendor/bin/robo run:tests --env=desktop: will run the default desktop testvendor/bin/robo run:tests --env=tablet: will run the test at 768px widthvendor/bin/robo run:tests --env=phone: will run the test at 480px width (and it will fail, but that's not the issue addressed in this PR).Notes
With this PR we switch from ordered arguments to named options. Previously we used the arguments only on Travis so this should not change anything in how we run the tests.