Allow captcha when submit a webllink #223

alikon · 2016-06-26T07:37:36Z

Pull Request for Issue #209 .

Summary of Changes

allow to use captcha when submit a weblink

Testing Instructions

use submit weblink enabling/disabling captcha settings

allow captcha on submit web link (1/5)

allow captcha on submit web link (2/5)

allow captcha on submit web link (3/5)

allow captcha on submit web link (4/5)

allow captcha on submit web link (5/5)

yvesh · 2016-06-26T09:14:47Z

@alikon Hey Nicola, works fine, but there are some small issues i found so far:

The tooltip text: Type in the textbox what you see in the image is not really matching for Recaptcha version 2 (where you don't fill out text boxes, but click images).

Some code style issues (see comments).

Thank you!

yvesh · 2016-06-26T09:15:39Z

src/components/com_weblinks/views/form/tmpl/edit.php

@@ -14,6 +14,17 @@
 JHtml::_('formbehavior.chosen', 'select');
 JHtml::_('behavior.modal', 'a.modal_jform_contenthistory');

+$captchaEnabled = false;
+$captchaSet = $this->params->get('captcha', JFactory::getApplication()->get('captcha', '0'));
+foreach (JPluginHelper::getPlugin('captcha') as $plugin)


A new empty line is missing before the foreach loop

chrisdavenport · 2016-06-26T09:28:20Z

A couple of issues:

If I fail the captcha the page reloads but all the form field entries are lost.
Perhaps move the captcha field to the end of the form?

CS fix

alikon · 2016-06-26T10:12:12Z

@yvesh

The tooltip text: Type in the textbox what you see in the image is not really matching for Recaptcha version

is like com_contact what should be the correct STRING ?

@chrisdavenport

Perhaps move the captcha field to the end of the form?

not sure should be better near the submit button ?

If I fail the captcha the page reloads but all the form field entries are lost.

any help ?

yvesh · 2016-06-26T10:19:46Z

@alikon Not sure on the text. Something more generic maybe, which fits both.

For example: Please answer the security question. But i am not a native speaker. @chrisdavenport What do you think?

If I fail the captcha the page reloads but all the form field entries are lost.

any help ?

This is not going to be implemented easily. For com_users the data the user entered during registration is saved in the session and then loaded again.

See this code as an example.

chrisdavenport · 2016-06-26T11:16:26Z

I checked with the en-GB team and because "I'm not a robot" is not a question, the suggested text is "Please complete the security check." There is a PR in the CMS repo for the same text: joomla/joomla-cms#10931

Good point about the submit buttons. Actually, I think the buttons should be moved to the end too. See, for example, the contact form.

Should be fairly simple to save the form data in the session as per com_users and also com_contact.

Simple XML CS joomla-extensions#223

@wojsmol

XML CS for joomla-extensions/pull/223 thanks @wojsmol

update captcha message like com_user, com_contatct #10931

handle session data 1(/2)

handle session data (2/2)

move buttons down

alikon · 2016-06-27T20:18:55Z

session form data
captcha & buttons moved down

....

chrisdavenport · 2016-06-27T20:29:28Z

I have tested this item ✅ successfully on d6a18f8

Works perfectly and looks good. Thanks Nicola. 😄

_{This comment was created with the J!Tracker Application at issues.joomla.org/weblinks/223.}

alikon · 2016-06-27T20:36:38Z

there is the need to add the lang string to the joomla-cms repo too ?
joomla/joomla-cms#10895 (comment)

yvesh · 2016-06-28T14:49:47Z

@alikon There is a slight css issue for me:

Imo it's not completely related to your PR, even the

element has that issue. This is a clean Joomla! staging / protostar + weblinks installation.

Everything else works as expected, great work Nicola!

alikon · 2016-06-28T18:21:43Z

@yvesh css is not my "comfort zone"

any help to fix CSS issue ?

alikon · 2016-06-29T10:37:03Z

...it happens only when editor is CodeMirror...

yvesh · 2016-06-29T19:35:25Z

@alikon it also happens without an editor. But you are right with TinyMCE it's fine.. Probably something which should be fixed in core (the row with buttons need to have width: 100% for the editor line, so there is no free space right of it).

We could fix it for weblinks with the following css:

#editor-xtd-buttons {
   width: 100%
}

@chrisdavenport What do you think? Core problem or weblinks?

dgrammatiko · 2016-06-29T20:17:06Z

@alikon @yvesh how about: joomla/joomla-cms#10970

alikon · 2016-06-30T05:39:59Z

maybe @dgt41 can evaluate my dirty fix on https://github.com/joomla/joomla-cms/blob/staging/templates/protostar/css/template.css#L2609
from

.btn-toolbar {
    font-size: 0;
    margin-top: 9px;
    margin-bottom: 9px;
}

to

.btn-toolbar {
    font-size: 0;
    margin-top: 9px;
    margin-bottom: 9px;
        width: 100%;
}

results is clean now, i think...

but i don't know if it is a goog fix .....

yvesh · 2016-06-30T05:52:05Z

@alikon looks fine for me, but not sure if that would cause other issues though. You could also just remove the pull-left class the editor-xtd-buttons div has. Not sure why that is there at all?

Is there a case were there is something located right to it on the same line?

// cc @dgt41

chrisdavenport · 2016-07-04T09:04:52Z

Any objections to merging this now?

alikon · 2016-07-04T09:14:12Z

For my knowledge of CSS the issue we have should be fixed on the CMS CSS side
We are waiting for some CSS expert answer which should be the right fix mine or Yves or ...
Evoking @dgt41

yvesh · 2016-07-04T16:03:28Z

@alikon The branch now has conflicts (Probably due to Tobias changes related to code style).

I think we can merge this PR. The CSS layout problem is a minor one and only occurs when you have no editor or CodeMirror. We should open an issue at core for that. The css code from Nicola looks fine, but i am not sure if it has side effects.

fix conflicts with joomla-extensions#231

alikon · 2016-07-04T18:13:56Z

yes please merge this PR

p.s.
cause i'm unable to find the latest damned branch conflicts 😭

jissues-bot · 2016-07-04T18:15:07Z

This PR has received new commits.

CC: @chrisdavenport

yvesh · 2016-07-04T18:30:54Z

@alikon i sent you an PR against your one, merging current master changes into it. (Test please)

Merged with master from weblinks

yvesh · 2016-07-04T18:39:24Z

Okay conflicts resolved. @chrisdavenport you can merge now.

alikon · 2016-07-04T18:39:59Z

thanks 1000 @yvesh

jissues-bot · 2016-07-04T18:45:07Z

This PR has received new commits.

CC: @chrisdavenport

chrisdavenport · 2016-07-04T21:32:20Z

Merging. Good work everyone. :-)

alikon added 5 commits June 26, 2016 09:22

allow captcha on submit web link

d4c0692

allow captcha on submit web link (1/5)

allow captcha on submit web link

5350f82

allow captcha on submit web link (2/5)

allow captcha on submit web link

4b8a01d

allow captcha on submit web link (3/5)

allow captcha on submit web link

d4d3531

allow captcha on submit web link (4/5)

allow captcha on submit web link

c53b971

allow captcha on submit web link (5/5)

yvesh reviewed Jun 26, 2016
View reviewed changes

CS fix

0141aa5

CS fix

XML CS for joomla-extensions#223

b7bdef0

Simple XML CS joomla-extensions#223

wojsmol mentioned this pull request Jun 26, 2016

XML CS for joomla-extensions/weblinks/pull/223 alikon/weblinks#2

Merged

alikon added 5 commits June 27, 2016 06:34

Merge pull request #2 from wojsmol/patch-5

dbb05c5

XML CS for joomla-extensions/pull/223 thanks @wojsmol

update captcha message

0fbd844

update captcha message like com_user, com_contatct #10931

handle session data

2ccafd9

handle session data 1(/2)

handle session data

2a1283d

handle session data (2/2)

move buttons down

d6a18f8

move buttons down

dgrammatiko mentioned this pull request Jun 29, 2016

Properly align content after XTD buttons joomla/joomla-cms#10970

Closed

alikon mentioned this pull request Jun 30, 2016

[com_content] - Allow captcha when submit article joomla/joomla-cms#10976

Closed

alikon added 2 commits July 4, 2016 19:47

fix conflicts with joomla-extensions#231

b508258

fix conflicts with joomla-extensions#231

fix conflicts with joomla-extensions#231

130ed0a

fix conflicts with joomla-extensions#231

Merge branch 'master' into nikolamconf

438a355

Merge pull request #3 from yvesh/nikolamconf

82bc274

Merged with master from weblinks

chrisdavenport merged commit 1680ec7 into joomla-extensions:master Jul 4, 2016

alikon deleted the patch-4 branch September 6, 2016 07:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow captcha when submit a webllink #223

Allow captcha when submit a webllink #223

alikon commented Jun 26, 2016

yvesh commented Jun 26, 2016

yvesh Jun 26, 2016

chrisdavenport commented Jun 26, 2016

alikon commented Jun 26, 2016

yvesh commented Jun 26, 2016 •

edited

chrisdavenport commented Jun 26, 2016

alikon commented Jun 27, 2016

chrisdavenport commented Jun 27, 2016

alikon commented Jun 27, 2016 •

edited

yvesh commented Jun 28, 2016

alikon commented Jun 28, 2016

alikon commented Jun 29, 2016

yvesh commented Jun 29, 2016 •

edited

dgrammatiko commented Jun 29, 2016

alikon commented Jun 30, 2016

yvesh commented Jun 30, 2016 •

edited

chrisdavenport commented Jul 4, 2016

alikon commented Jul 4, 2016

yvesh commented Jul 4, 2016 •

edited

alikon commented Jul 4, 2016

jissues-bot commented Jul 4, 2016

yvesh commented Jul 4, 2016 •

edited

yvesh commented Jul 4, 2016 •

edited

alikon commented Jul 4, 2016

jissues-bot commented Jul 4, 2016

chrisdavenport commented Jul 4, 2016

Allow captcha when submit a webllink #223

Allow captcha when submit a webllink #223

Conversation

alikon commented Jun 26, 2016

Summary of Changes

Testing Instructions

yvesh commented Jun 26, 2016

yvesh Jun 26, 2016

Choose a reason for hiding this comment

chrisdavenport commented Jun 26, 2016

alikon commented Jun 26, 2016

yvesh commented Jun 26, 2016 • edited

chrisdavenport commented Jun 26, 2016

alikon commented Jun 27, 2016

chrisdavenport commented Jun 27, 2016

alikon commented Jun 27, 2016 • edited

yvesh commented Jun 28, 2016

alikon commented Jun 28, 2016

alikon commented Jun 29, 2016

yvesh commented Jun 29, 2016 • edited

dgrammatiko commented Jun 29, 2016

alikon commented Jun 30, 2016

yvesh commented Jun 30, 2016 • edited

chrisdavenport commented Jul 4, 2016

alikon commented Jul 4, 2016

yvesh commented Jul 4, 2016 • edited

alikon commented Jul 4, 2016

jissues-bot commented Jul 4, 2016

yvesh commented Jul 4, 2016 • edited

yvesh commented Jul 4, 2016 • edited

alikon commented Jul 4, 2016

jissues-bot commented Jul 4, 2016

chrisdavenport commented Jul 4, 2016

yvesh commented Jun 26, 2016 •

edited

alikon commented Jun 27, 2016 •

edited

yvesh commented Jun 29, 2016 •

edited

yvesh commented Jun 30, 2016 •

edited

yvesh commented Jul 4, 2016 •

edited

yvesh commented Jul 4, 2016 •

edited

yvesh commented Jul 4, 2016 •

edited