Drone.io integration for Weblinks #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - sleep 3 | ||
| - fluxbox & | ||
| - vendor/bin/robo run:tests | ||
| - echo "Finished tests at $(date)" |
There was a problem hiding this comment.
Hey Jelle, we are testing and comparing the performance versus travis currently ;-) That's the reason i added it.
There was a problem hiding this comment.
i think the time is always displayed. So you don't need to add it
| - cd /tests/www | ||
| - export DISPLAY=:0 | ||
| - Xvfb -screen 0 1024x768x24 -ac +extension GLX +render -noreset > /dev/null 2>&1 & | ||
| - sleep 3 |
There was a problem hiding this comment.
not sure, but this type of errors use to happen in Travis too. We solved by increasing the sleep time giving more time Xvfb-fluxbox to launch and they dissapeared:
...
Failed to read: session.screen0.menu.alpha
Setting default value
Failed to read: session.screen0.menuDelay
Setting default value
...
|
Tests passing at http://82.165.166.30/joomla-extensions/weblinks/5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Integration of drone.io into weblinks
Testing Instructions
Review and check log of drone.io
//cc @puneet0191 @javigomez