Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle situation where webslinks are trashed within trashed categories #496

Merged
merged 1 commit into from
May 20, 2022

Conversation

GeraintEdwards
Copy link

Summary of Changes

Ensure trashed weblinks and trashed categories are handled correctly. Revised code mirrors the code used in Joomla core e.g. com_content

Testing Instructions

Create a weblink category and a weblink within it. Trash the weblink and then trash the category . Then try rebuilding the finder index.

Expected result

Index is created correctly

Actual result

Error value of 'state' column is outside supported range and indexing crashes

Problem is because the trashed state of -2 can't be stored in the finder_taxonomy table where state is unsigned.

Documentation Changes Required

None

@chmst
Copy link
Contributor

chmst commented May 18, 2022

Thank you - will test asap. How nice to see you as first time contributor :)

@joomdonation
Copy link
Contributor

I must be honest that I don't understand our Smart search works internal. However, I have compared the modified code in this PR with the code from finder plugin for com_content and it looks good. So I'm merging this PR. @chmst If you can run a test to make sure nothing broken, that would be great (I tested it myself, too)

Thanks @GeraintEdwards.

@joomdonation joomdonation merged commit 6c3d57c into joomla-extensions:4.0-dev May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants