PHPCS fixes

.travis.yml

@@ -44,4 +44,4 @@ before_script:
 
 script:
   - vendor/bin/phpunit
-  - if [ "$RUN_PHPCS" == "yes" ]; then vendor/bin/phpcs --config-set installed_paths vendor/joomla/coding-standards && vendor/bin/phpcs -p --report=full --extensions=php --standard=Joomla Storage/ Session.php Storage.php; fi;
+  - if [ "$RUN_PHPCS" == "yes" ]; then vendor/bin/phpcs --config-set installed_paths vendor/joomla/coding-standards && vendor/bin/phpcs -p --report=full --extensions=php --standard=ruleset.xml Storage/ Session.php Storage.php; fi;

Storage.php

@@ -139,7 +139,7 @@ public function close()
 	 */
 	public function read($id)
 	{
-		return;
+		return '';
 	}
 
 	/**

Storage/Database.php

@@ -70,8 +70,8 @@ public function read($id)
 			// Get the session data from the database table.
 			$query = $this->db->getQuery(true);
 			$query->select($this->db->quoteName('data'))
-			->from($this->db->quoteName('#__session'))
-			->where($this->db->quoteName('session_id') . ' = ' . $this->db->quote($id));
+				->from($this->db->quoteName('#__session'))
+				->where($this->db->quoteName('session_id') . ' = ' . $this->db->quote($id));
 
 			$this->db->setQuery($query);
 
@@ -100,9 +100,9 @@ public function write($id, $data)
 		{
 			$query = $this->db->getQuery(true);
 			$query->update($this->db->quoteName('#__session'))
-			->set($this->db->quoteName('data') . ' = ' . $this->db->quote($data))
-			->set($this->db->quoteName('time') . ' = ' . $this->db->quote((int) time()))
-			->where($this->db->quoteName('session_id') . ' = ' . $this->db->quote($id));
+				->set($this->db->quoteName('data') . ' = ' . $this->db->quote($data))
+				->set($this->db->quoteName('time') . ' = ' . $this->db->quote((int) time()))
+				->where($this->db->quoteName('session_id') . ' = ' . $this->db->quote($id));
 
 			// Try to update the session data in the database table.
 			$this->db->setQuery($query);
@@ -139,7 +139,7 @@ public function destroy($id)
 		{
 			$query = $this->db->getQuery(true);
 			$query->delete($this->db->quoteName('#__session'))
-			->where($this->db->quoteName('session_id') . ' = ' . $this->db->quote($id));
+				->where($this->db->quoteName('session_id') . ' = ' . $this->db->quote($id));
 
 			// Remove a session from the database.
 			$this->db->setQuery($query);
@@ -171,7 +171,7 @@ public function gc($lifetime = 1440)
 		{
 			$query = $this->db->getQuery(true);
 			$query->delete($this->db->quoteName('#__session'))
-			->where($this->db->quoteName('time') . ' < ' . $this->db->quote((int) $past));
+				->where($this->db->quoteName('time') . ' < ' . $this->db->quote((int) $past));
 
 			// Remove expired sessions from the database.
 			$this->db->setQuery($query);

Storage/Xcache.php

@@ -54,7 +54,7 @@ public function read($id)
 		// Check if id exists
 		if (!xcache_isset($sess_id))
 		{
-			return;
+			return '';
 		}
 
 		return (string) xcache_get($sess_id);

ruleset.xml

@@ -0,0 +1,23 @@
+<?xml version="1.0"?>
+<ruleset name="Joomla">
+
+    <arg name="report" value="full"/>
+    <arg name="tab-width" value="4"/>
+    <arg name="encoding" value="utf-8"/>
+    <arg value="sp"/>
+    <arg name="colors" />
+
+    <!-- Exclude folders not containing production code -->
+    <exclude-pattern>*/.github/*</exclude-pattern>
+    <exclude-pattern>*/.travis/*</exclude-pattern>
+
+    <!-- Exclude 3rd party libraries. -->
+    <exclude-pattern>*/vendor/*</exclude-pattern>
+
+    <rule ref="Joomla">
+        <!-- Variables inherited from the PHP SessionHandlerInterface definition are named in snake case -->
+        <exclude name="Joomla.NamingConventions.ValidVariableName"/>
+        <!-- Required due to legacy methods being named with a leading underscore, should be fixed in 2.0 -->
+        <exclude name="Joomla.NamingConventions.ValidFunctionName.MethodUnderscore"/>
+    </rule>
+</ruleset>