Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PHP 7.4 deprecated curly brace access #23

Merged
merged 4 commits into from Aug 4, 2019
Merged

Remove PHP 7.4 deprecated curly brace access #23

merged 4 commits into from Aug 4, 2019

Conversation

wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Aug 4, 2019

Fixes PHP deprecation warnings in PHP 7.4 and adds testing (as an allowed failure for now)

@mbabker
Copy link
Contributor

mbabker commented Aug 4, 2019

Note the changes somewhere similar to the mbstring.func_overload check please.

@wilsonge
Copy link
Contributor Author

wilsonge commented Aug 4, 2019

Done

@mbabker mbabker merged commit 33944ac into master Aug 4, 2019
@mbabker mbabker deleted the feature/fix-php74 branch August 4, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wilsonge @mbabker