Added bump version task for replacing the DEPLOY_VERSION placeholder #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he extension source
jatitoam
reviewed
Jan 16, 2017
| @@ -69,11 +69,6 @@ public function __construct($params = array()) | |||
| $this->loadConfiguration($params); | |||
| $this->determineOperatingSystem(); | |||
| $this->determineSourceFolder(); | |||
|
|
|||
| // Registers the application to run Robo commands | |||
There was a problem hiding this comment.
I sent a fix for this in #30 since it needs to be set before the configuration. I'll fix that PR to get it merged asap.
jatitoam
approved these changes
Jan 16, 2017
|
Great one @yvesh thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new Robo Task for replacing
__DEPLOY_VERSION__in the extensions source code.Testing Instructions
Apply the patch to the weblinks JoRobo version.
And modify the since tag of an PHP file in the source to:
@since __DEPLOY_VERSION__After this run:
vendor/bin/robo bumpfrom your cli
Check that
__DEPLOY_VERSION__has been replaced by the version set in the jorobo.ini (3.6.0-beta currently).Ping @chrisdavenport here