Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research request: Tags #16

Closed
armenos opened this issue Aug 31, 2017 · 8 comments
Closed

Research request: Tags #16

armenos opened this issue Aug 31, 2017 · 8 comments

Comments

@armenos
Copy link

armenos commented Aug 31, 2017

Research request: Tags

Has anyone time to review this code about tags
@dgt41 needs requirements for this functionality
Can we do a research on this?

https://codepen.io/dgt41/pen/YxdNpw?editors=0010

When we have tested en have done research we can make a documentation.

@zwiastunsw
Copy link
Contributor

  1. Add a tag only with the keyboard - OK
  2. Announcing the task of creating a tag by the screen reader - OK.
  3. Unfortunately, I have not found a way to remove unnecessary tags just by using the keyboard.
    In conclusion: At this moment the Tags custom-element does not meet accessibility requirements.

@dgrammatiko
Copy link

@zwiastunsw Thanks for the review, I know its not there from accessibility point of view, but that is the reason I ask you to help.
What I need in more detail is:

  • this new tags element needs a way to remove tags through keyboard, what will be a good workflow for that (e.g. tab through and press delete on the selected tag?)
  • There is another feature: you can drag and drop to rearrange the order of the tags (with mouse). How can this be implemented for keyboard users (I have no idea how to make drag and drop keyboard accessible, so this team needs to guide me)

Also there will be a drop down for the possible tags that are already stored in the database, but for that we will have another issue, after we finished this first part...

@zwiastunsw
Copy link
Contributor

I'll try to say something tomorrow.

@dgrammatiko
Copy link

@zwiastunsw https://codepen.io/dgt41/pen/KvbbdE this is closer to what we need (keyboard support except drag and drop)

@zwiastunsw
Copy link
Contributor

Yes! It is much better. Now we need to:

  1. The screen reader announced the focus tag.
  2. The screen reader announced the removal of the tag
  3. The way to change the order of tags using the keyboard

@dgrammatiko
Copy link

@zwiastunsw any idea of what aria html markup we should to get the reader announcements?

@zwiastunsw
Copy link
Contributor

I have no idea.
I have found such a rich development that can help solve problems:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants