New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation issues #176
Comments
Agree about title. Anyone knows allowed values? :)
For example? |
At https://github.com/joomla/jissues/blob/framework/src/App/Tracker/Controller/Hooks/ReceivePullsHook.php#L118 add in |
A little bit confusing to have branch name as a build, but if we do not have any other option then it's ok. |
On Joomlacode, I often put in 'master' for the build to indicate the current master. So it would either be '2.5.x', 'staging', or 'master' when coming through GitHub. |
Did not know that. Then the only problem now how to know min-max length for the title? I googled around and did not found anything... |
We might abuse a bit and just try out... jtester/tests#26 - Title length I wouldn't go any further here but I don't think there is any "visible" limit on their side... |
Just tested the title submitting #177 - minimal title length allowed is 1 char and the maximum is 244 chars :) |
255 👅 |
Well :) One space was missed by me 👅 |
I've deployed the latest changes to the server, we'll see what happens now. |
On joomla/joomla-cms#2508 still got a |
Oh my :) It's because of the exclamation mark. We should add it too of course. |
This 4a1e568 should fix it. I hope 😺 |
Cool - I'll deploy it tonight |
Sounds silly, but the next char that comes to my mind is a |
I wish there was somewhere that their validator was posted. FYI latest code is deployed. |
Everything is ok? |
#Merge #204 😄 |
Sounds like we need to make a test issue trying to pass all the keyboard into the title 😆 |
I was talking about the project with the folks of the german http://www.joomla-bugs.de/ throwing around crazy ideas about a multi-lingual tracker.... so, those |
Hmm, currently our regex in the table class supports Unicode chars: But JS is not: I am not a prof in regex 😊 But on SO found this question. As far as I understand this could work: If not we will need some external library to achieve that. |
Which brings up the interesting question if it might be possible to have one rule "provider" for both client and server side validation. |
Well I just started #210 and it allowed all the chars... Seems we do not need to filter the title at all? |
I was about to say that :-) Sent from my Android =;)
|
Hehe :) Will post a fix tomorrow 🎉 |
Should be fixed. If not please leave a note here 😆 |
I finally got around to deploying the latest up, so we'll see how it all goes. |
Some things need to get cleaned up with the validation rules IMO. Pull requests aren't merging into the app anymore, these being the common reasons:
Title should match exactly what GitHub allows via the site here in terms of lengths. Build can be handled by defaulting to the destination branch in the hooks.
The text was updated successfully, but these errors were encountered: