-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
403 API rate limit exceeded for jissues-bot on saving an issue #617
Comments
We're going to need folks to stop working for the hour 😝 Maybe the CMS repo is getting big enough that we need another bot? |
hmm and/or reduce the github api calls? The issue comes from here: |
also no sync of comments here: http://issues.joomla.org/tracker/joomla-cms/5984 from here joomla/joomla-cms#5984 |
maybe also related to: #611 and similiar? |
and Brian can perform it as he use his own account and not the bot: |
I've resent the missing events. It's hard to cut back on the number of calls to the GitHub API. The block you highlighted is what sends updates from the app to GitHub immediately upon save. The first request tries as the authenticated user and if they don't have permission to perform the action, the bot picks up the slack. We're only making requests as needed. An issue we're hitting is there are cron jobs now running every 5 minutes except for :25 and :55 after the hour to support all of the repositories in the live app. If I'm not mistaken, all use the @jissues-bot account. So, we either need more bots or we have to give more users permissions on the main repos to perform the same actions, and the latter is not preferred. |
For reference, the current cron schedule: 0,30 * * * * php cli/tracker.php get project --all --project=2 --log=cron.log >/dev/null 2>&1
5,35 * * * * php cli/tracker.php get project --all --project=5 --log=cron.log >/dev/null 2>&1
10,40 * * * * php cli/tracker.php get project --all --project=1 --log=cron.log >/dev/null 2>&1
15,45 * * * * php cli/tracker.php get project --all --project=6 --log=cron.log >/dev/null 2>&1
20,50 * * * * php cli/tracker.php get project --all --project=4 --log=cron.log >/dev/null 2>&1 ID mapping:
|
hmm so i think we have tree options:
One of the problems is that if more users gets enabled as JBS and can change status and comments via jissues the limit will be exceeded faster than now. ATM we have only a smal number of users that uses jissues for actions that needs the bot. If i see it correct. |
Folks we have this functionality actually implemented. We have one (or more) GitHub (bot) account settings in So the thing to do here would be to create a project specific bot user account (a That should be it for the moment, unless those JBS folks are getting high on pizza and pass the 5k/hour limit in one of those global bug squashing sessions 😉 @mbabker regarding the cron script: maybe you could write the output to a log file instead of /dev/null including stderr, so maybe PHP errors get caught here that do not enter in our regular cron log, so maybe we get some hints about what is going wrong currently.. |
I can do that. Just need to remember to cycle them off the server; I cleared 8 months (and something like 3 GB) of un-read log files that were in the mail queue out when I added that dev/null piece. |
No logrotate or similar available?... The most important thing right now is to not use the bot account from the config.json in project edit bot settings. |
No |
I've got the cron jobs updated to capture output and logging on the server. If we want to add some sort of UI for them, I'm writing them as .txt files to a cronlogs folder which would be at the repo root here. |
Welcome @joomla-cms-bot to GitHub, this bot shall take on responsibility for the CMS repo. |
That sounds terrific :) Welcome on board @joomla-cms-bot 😋 |
Nice to meet you @joomla-cms-bot I hope you are going to be well behaved On 6 February 2015 at 00:07, Nikolai Plath notifications@github.com wrote:
Brian Teeman |
So I don't know if something changed in the GitHub API (which might explain #607) but the last cron run on this repo updated 169 issues. If I'm not mistaken, I thought we were only scanning for issues that might have changed between runs. Cron log dump follows: ------------------------------------------------------------
Joomla! Tracker CLI Application
1.0.0-beta
------------------------------------------------------------
------------------------------------------------------------
Retrieve Project
------------------------------------------------------------
GitHub rate limit:... 5000 (remaining: 4906)
Updating project info for project: joomla/jissues
------------------------------------------------------------
Retrieve Labels
------------------------------------------------------------
Fetching labels...ok
------------------------------------------------------------
Retrieve Milestones
------------------------------------------------------------
Fetching milestones...ok
------------------------------------------------------------
Retrieve Issues
------------------------------------------------------------
Retrieving open items from GitHub...(61)
Retrieving closed items from GitHub...(100)(100)(100)(100)(100)(57)
Adding issues to the database...
[==========================>] 618/618 00:36.23 ETA: 00:00.00
------------------------------------------------------------
Retrieve Comments
------------------------------------------------------------
Fetching comments for 169 modified issues from GitHub...
[==========================>] 169/169 01:08.12 ETA: 00:00.00
ok
Processing comments for 169 modified issues...
Processing 3 comments for issue # 5 (1/169)
[==============================>] 3/3 00:00.02 ETA: 00:00.00
Processing 11 comments for issue # 6 (2/169)
[============================>] 11/11 00:00.07 ETA: 00:00.00
Processing 60 comments for issue # 166 (3/169)
[============================>] 60/60 00:00.43 ETA: 00:00.00
Processing 16 comments for issue # 182 (4/169)
[============================>] 16/16 00:00.11 ETA: 00:00.00
Processing 13 comments for issue # 184 (5/169)
[============================>] 13/13 00:00.09 ETA: 00:00.00
Processing 18 comments for issue # 203 (6/169)
[============================>] 18/18 00:00.13 ETA: 00:00.00
Processing 14 comments for issue # 208 (7/169)
[============================>] 14/14 00:00.09 ETA: 00:00.00
Processing 10 comments for issue # 213 (8/169)
[============================>] 10/10 00:00.07 ETA: 00:00.00
Processing 10 comments for issue # 220 (9/169)
[============================>] 10/10 00:00.07 ETA: 00:00.00
Processing 10 comments for issue # 240 (10/169)
[============================>] 10/10 00:00.07 ETA: 00:00.00
Processing one comment for issue # 256 (11/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing one comment for issue # 257 (12/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing one comment for issue # 258 (13/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
No comments for issue # 260
No comments for issue # 261
Processing one comment for issue # 266 (14/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing 12 comments for issue # 273 (15/169)
[============================>] 12/12 00:00.08 ETA: 00:00.00
Processing 7 comments for issue # 289 (16/169)
[==============================>] 7/7 00:00.04 ETA: 00:00.00
Processing 14 comments for issue # 314 (17/169)
[============================>] 14/14 00:00.10 ETA: 00:00.00
Processing 45 comments for issue # 318 (18/169)
[============================>] 45/45 00:00.33 ETA: 00:00.00
Processing 9 comments for issue # 326 (19/169)
[==============================>] 9/9 00:00.06 ETA: 00:00.00
Processing 23 comments for issue # 346 (20/169)
[============================>] 23/23 00:00.16 ETA: 00:00.00
Processing one comment for issue # 373 (21/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing 3 comments for issue # 412 (22/169)
[==============================>] 3/3 00:00.01 ETA: 00:00.00
Processing 27 comments for issue # 425 (23/169)
[============================>] 27/27 00:00.20 ETA: 00:00.00
No comments for issue # 428
Processing 11 comments for issue # 429 (24/169)
[============================>] 11/11 00:00.07 ETA: 00:00.00
Processing 16 comments for issue # 434 (25/169)
[============================>] 16/16 00:00.11 ETA: 00:00.00
Processing 6 comments for issue # 439 (26/169)
[==============================>] 6/6 00:00.04 ETA: 00:00.00
Processing 10 comments for issue # 447 (27/169)
[============================>] 10/10 00:00.07 ETA: 00:00.00
Processing 2 comments for issue # 448 (28/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing 20 comments for issue # 449 (29/169)
[============================>] 20/20 00:00.14 ETA: 00:00.00
Processing 8 comments for issue # 452 (30/169)
[==============================>] 8/8 00:00.05 ETA: 00:00.00
Processing 6 comments for issue # 453 (31/169)
[==============================>] 6/6 00:00.04 ETA: 00:00.00
Processing 17 comments for issue # 458 (32/169)
[============================>] 17/17 00:00.12 ETA: 00:00.00
Processing 4 comments for issue # 469 (33/169)
[==============================>] 4/4 00:00.02 ETA: 00:00.00
Processing 12 comments for issue # 471 (34/169)
[============================>] 12/12 00:00.08 ETA: 00:00.00
Processing one comment for issue # 472 (35/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing one comment for issue # 477 (36/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing one comment for issue # 478 (37/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing 6 comments for issue # 479 (38/169)
[==============================>] 6/6 00:00.04 ETA: 00:00.00
Processing 10 comments for issue # 480 (39/169)
[============================>] 10/10 00:00.07 ETA: 00:00.00
Processing 11 comments for issue # 481 (40/169)
[============================>] 11/11 00:00.07 ETA: 00:00.00
Processing 4 comments for issue # 482 (41/169)
[==============================>] 4/4 00:00.02 ETA: 00:00.00
Processing 8 comments for issue # 483 (42/169)
[==============================>] 8/8 00:00.05 ETA: 00:00.00
Processing 5 comments for issue # 484 (43/169)
[==============================>] 5/5 00:00.03 ETA: 00:00.00
Processing 8 comments for issue # 485 (44/169)
[==============================>] 8/8 00:00.05 ETA: 00:00.00
Processing 4 comments for issue # 486 (45/169)
[==============================>] 4/4 00:00.02 ETA: 00:00.00
Processing 9 comments for issue # 487 (46/169)
[==============================>] 9/9 00:00.06 ETA: 00:00.00
Processing 6 comments for issue # 488 (47/169)
[==============================>] 6/6 00:00.04 ETA: 00:00.00
No comments for issue # 489
Processing 12 comments for issue # 490 (48/169)
[============================>] 12/12 00:00.08 ETA: 00:00.00
Processing 4 comments for issue # 491 (49/169)
[==============================>] 4/4 00:00.02 ETA: 00:00.00
Processing 3 comments for issue # 492 (50/169)
[==============================>] 3/3 00:00.01 ETA: 00:00.00
Processing 5 comments for issue # 493 (51/169)
[==============================>] 5/5 00:00.03 ETA: 00:00.00
Processing 2 comments for issue # 494 (52/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing 4 comments for issue # 495 (53/169)
[==============================>] 4/4 00:00.02 ETA: 00:00.00
Processing 5 comments for issue # 496 (54/169)
[==============================>] 5/5 00:00.03 ETA: 00:00.00
Processing 10 comments for issue # 497 (55/169)
[============================>] 10/10 00:00.07 ETA: 00:00.00
Processing 7 comments for issue # 498 (56/169)
[==============================>] 7/7 00:00.05 ETA: 00:00.00
Processing 4 comments for issue # 499 (57/169)
[==============================>] 4/4 00:00.02 ETA: 00:00.00
Processing 8 comments for issue # 500 (58/169)
[==============================>] 8/8 00:00.05 ETA: 00:00.00
Processing 6 comments for issue # 501 (59/169)
[==============================>] 6/6 00:00.04 ETA: 00:00.00
Processing 7 comments for issue # 502 (60/169)
[==============================>] 7/7 00:00.04 ETA: 00:00.00
Processing one comment for issue # 503 (61/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
No comments for issue # 504
Processing 3 comments for issue # 505 (62/169)
[==============================>] 3/3 00:00.02 ETA: 00:00.00
Processing 4 comments for issue # 506 (63/169)
[==============================>] 4/4 00:00.02 ETA: 00:00.00
Processing 2 comments for issue # 507 (64/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing 3 comments for issue # 508 (65/169)
[==============================>] 3/3 00:00.01 ETA: 00:00.00
Processing 4 comments for issue # 509 (66/169)
[==============================>] 4/4 00:00.02 ETA: 00:00.00
Processing 16 comments for issue # 510 (67/169)
[============================>] 16/16 00:00.11 ETA: 00:00.00
Processing 2 comments for issue # 511 (68/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing 2 comments for issue # 512 (69/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing 2 comments for issue # 513 (70/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing 10 comments for issue # 514 (71/169)
[============================>] 10/10 00:00.06 ETA: 00:00.00
Processing 6 comments for issue # 515 (72/169)
[==============================>] 6/6 00:00.04 ETA: 00:00.00
Processing 2 comments for issue # 516 (73/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing 3 comments for issue # 517 (74/169)
[==============================>] 3/3 00:00.01 ETA: 00:00.00
Processing 3 comments for issue # 518 (75/169)
[==============================>] 3/3 00:00.01 ETA: 00:00.00
No comments for issue # 519
Processing 24 comments for issue # 520 (76/169)
[============================>] 24/24 00:00.18 ETA: 00:00.00
Processing 2 comments for issue # 521 (77/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing 3 comments for issue # 522 (78/169)
[==============================>] 3/3 00:00.02 ETA: 00:00.00
Processing 15 comments for issue # 523 (79/169)
[============================>] 15/15 00:00.10 ETA: 00:00.00
No comments for issue # 524
Processing 15 comments for issue # 525 (80/169)
[============================>] 15/15 00:00.10 ETA: 00:00.00
Processing 2 comments for issue # 526 (81/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing 3 comments for issue # 527 (82/169)
[==============================>] 3/3 00:00.01 ETA: 00:00.00
Processing 4 comments for issue # 528 (83/169)
[==============================>] 4/4 00:00.02 ETA: 00:00.00
Processing 2 comments for issue # 529 (84/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing 2 comments for issue # 530 (85/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing 5 comments for issue # 531 (86/169)
[==============================>] 5/5 00:00.03 ETA: 00:00.00
Processing 5 comments for issue # 532 (87/169)
[==============================>] 5/5 00:00.03 ETA: 00:00.00
Processing 4 comments for issue # 533 (88/169)
[==============================>] 4/4 00:00.02 ETA: 00:00.00
Processing 3 comments for issue # 534 (89/169)
[==============================>] 3/3 00:00.01 ETA: 00:00.00
Processing one comment for issue # 535 (90/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
No comments for issue # 536
No comments for issue # 537
Processing 8 comments for issue # 539 (91/169)
[==============================>] 8/8 00:00.05 ETA: 00:00.00
Processing 4 comments for issue # 540 (92/169)
[==============================>] 4/4 00:00.02 ETA: 00:00.00
Processing one comment for issue # 541 (93/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing 3 comments for issue # 542 (94/169)
[==============================>] 3/3 00:00.01 ETA: 00:00.00
Processing 6 comments for issue # 543 (95/169)
[==============================>] 6/6 00:00.04 ETA: 00:00.00
Processing 5 comments for issue # 544 (96/169)
[==============================>] 5/5 00:00.03 ETA: 00:00.00
Processing one comment for issue # 545 (97/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing one comment for issue # 546 (98/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing 4 comments for issue # 547 (99/169)
[==============================>] 4/4 00:00.02 ETA: 00:00.00
Processing one comment for issue # 548 (100/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing one comment for issue # 549 (101/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing 2 comments for issue # 550 (102/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing one comment for issue # 551 (103/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing 2 comments for issue # 552 (104/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing 3 comments for issue # 553 (105/169)
[==============================>] 3/3 00:00.01 ETA: 00:00.00
Processing 8 comments for issue # 554 (106/169)
[==============================>] 8/8 00:00.05 ETA: 00:00.00
Processing 2 comments for issue # 555 (107/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing 21 comments for issue # 556 (108/169)
[============================>] 21/21 00:00.15 ETA: 00:00.00
Processing one comment for issue # 557 (109/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing 6 comments for issue # 559 (110/169)
[==============================>] 6/6 00:00.04 ETA: 00:00.00
Processing 21 comments for issue # 560 (111/169)
[============================>] 21/21 00:00.15 ETA: 00:00.00
Processing 8 comments for issue # 561 (112/169)
[==============================>] 8/8 00:00.05 ETA: 00:00.00
Processing 7 comments for issue # 562 (113/169)
[==============================>] 7/7 00:00.04 ETA: 00:00.00
Processing 29 comments for issue # 563 (114/169)
[============================>] 29/29 00:00.21 ETA: 00:00.00
Processing 8 comments for issue # 569 (115/169)
[==============================>] 8/8 00:00.05 ETA: 00:00.00
Processing 10 comments for issue # 570 (116/169)
[============================>] 10/10 00:00.07 ETA: 00:00.00
Processing 3 comments for issue # 571 (117/169)
[==============================>] 3/3 00:00.01 ETA: 00:00.00
Processing 3 comments for issue # 572 (118/169)
[==============================>] 3/3 00:00.01 ETA: 00:00.00
Processing 19 comments for issue # 573 (119/169)
[============================>] 19/19 00:00.14 ETA: 00:00.00
Processing one comment for issue # 574 (120/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing 2 comments for issue # 575 (121/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing 4 comments for issue # 576 (122/169)
[==============================>] 4/4 00:00.02 ETA: 00:00.00
Processing 2 comments for issue # 577 (123/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing 7 comments for issue # 578 (124/169)
[==============================>] 7/7 00:00.04 ETA: 00:00.00
Processing 8 comments for issue # 579 (125/169)
[==============================>] 8/8 00:00.05 ETA: 00:00.00
Processing one comment for issue # 580 (126/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing 4 comments for issue # 581 (127/169)
[==============================>] 4/4 00:00.02 ETA: 00:00.00
Processing 6 comments for issue # 582 (128/169)
[==============================>] 6/6 00:00.04 ETA: 00:00.00
Processing 3 comments for issue # 583 (129/169)
[==============================>] 3/3 00:00.02 ETA: 00:00.00
Processing 3 comments for issue # 584 (130/169)
[==============================>] 3/3 00:00.01 ETA: 00:00.00
Processing one comment for issue # 585 (131/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing 20 comments for issue # 586 (132/169)
[============================>] 20/20 00:00.14 ETA: 00:00.00
No comments for issue # 587
Processing 2 comments for issue # 588 (133/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
No comments for issue # 590
Processing one comment for issue # 591 (134/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing 5 comments for issue # 592 (135/169)
[==============================>] 5/5 00:00.03 ETA: 00:00.00
Processing 2 comments for issue # 593 (136/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing one comment for issue # 594 (137/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing 14 comments for issue # 595 (138/169)
[============================>] 14/14 00:00.10 ETA: 00:00.00
Processing 5 comments for issue # 596 (139/169)
[==============================>] 5/5 00:00.03 ETA: 00:00.00
Processing 2 comments for issue # 597 (140/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing 20 comments for issue # 598 (141/169)
[============================>] 20/20 00:00.14 ETA: 00:00.00
Processing 2 comments for issue # 599 (142/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing 3 comments for issue # 600 (143/169)
[==============================>] 3/3 00:00.02 ETA: 00:00.00
Processing one comment for issue # 601 (144/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
No comments for issue # 602
Processing 3 comments for issue # 603 (145/169)
[==============================>] 3/3 00:00.02 ETA: 00:00.00
Processing one comment for issue # 604 (146/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing 2 comments for issue # 605 (147/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing 7 comments for issue # 606 (148/169)
[==============================>] 7/7 00:00.04 ETA: 00:00.00
Processing 5 comments for issue # 607 (149/169)
[==============================>] 5/5 00:00.03 ETA: 00:00.00
No comments for issue # 609
Processing 2 comments for issue # 610 (150/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing one comment for issue # 612 (151/169)
[==============================>] 1/1 00:00.00 ETA: 00:00.00
Processing 2 comments for issue # 614 (152/169)
[==============================>] 2/2 00:00.01 ETA: 00:00.00
Processing 3 comments for issue # 615 (153/169)
[==============================>] 3/3 00:00.02 ETA: 00:00.00
No comments for issue # 616
Processing 16 comments for issue # 617 (154/169)
[============================>] 16/16 00:00.93 ETA: 00:00.00
No comments for issue # 618
ok
------------------------------------------------------------
Retrieve Events
------------------------------------------------------------
Fetch events for 169 issues from GitHub...
[==========================>] 169/169 01:08.80 ETA: 00:00.00
ok
Adding events to the database...
[==========================>] 169/169 00:02.32 ETA: 00:00.00
ok
------------------------------------------------------------
Retrieve Avatars
------------------------------------------------------------
[========================>] 1361/1361 00:00.06 ETA: 00:00.00
________________________________________
Execution time: 193 sec. |
@mbabker what does it mean? |
All the failures are because of the API limit being reached. I just changed the hook controllers to use a bot defined account if it exists, so now the CMS hooks should start using the new bot. |
Ah I see now 61ca18e |
I've also brought @joomla-bot into action and that should help with some of the cron job stuff. |
Are we good here? |
I'd say so. Haven't heard of any failures in the last week and don't see any failed GitHub webhooks in the logs. |
Steps to reproduce the issue
Try to save a issue on issues.joomla.org
Expected result
issue gets saved
Actual result
The text was updated successfully, but these errors were encountered: