Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Powered by PHPStorm" link to the footer #179

Merged
merged 0 commits into from Nov 17, 2013
Merged

Conversation

elkuku
Copy link
Contributor

@elkuku elkuku commented Nov 11, 2013

As discussed here: https://groups.google.com/forum/#!topic/joomla-dev-cms/-p23OoOi6kA


From my own personal point of view this is not so much about giving something back. In fact I am using my own (paid) license, even for my community contributions.

It's just to say:
PHPStorm is a great piece of software and we are using it extensively during the development of the JTracker Application.
aka "Powered by" - please find some appropriate (short) wording ;)

@dbhurley
Copy link
Contributor

I don't think this is necessary or appropriate. I use Sublime Text 2, and we don't put anything about that in footer. Nor do we do anything for others.

That being said, I completely agree with recognizing them and making sure they receive recognition for their donation of their product. There were some other suggestions in the mailing list that would work well I believe. We should explore one of those options for recognition and appreciation.

@dbhurley
Copy link
Contributor

I didn't mean for that to sound too harsh. I apologize. Perhaps changing the wording to not say "Powered by" would make this ok. I know we want to recognize them somewhere. 👍

@b2z
Copy link
Member

b2z commented Nov 11, 2013

@dbhurley :) I am not against BTW.

@elkuku
Copy link
Contributor Author

elkuku commented Nov 11, 2013

Well, since english is not my primary language, there may be different understandings of "Power"... I'm sure we find something we all could agree on 😉

@davidhurley
Copy link
Contributor

Yep, exactly my thoughts.

Thanks,
David Hurley
On Nov 11, 2013 1:02 PM, "Nikolai Plath" notifications@github.com wrote:

Well, since english is not my primary language, there may be different
understandings of "Power"... I'm sure we find something we all could agree
on [image: 😉]


Reply to this email directly or view it on GitHubhttps://github.com//pull/179#issuecomment-28223510
.

@betweenbrain
Copy link
Contributor

Is there any precent of recognizing support for the project like this?

I would certainly like to see their contribution recognized appropriately.

Best,

Matt Thomas
Founder betweenbrain™
Lead Developer Construct Template Development Framework
Phone: 203.632.9322
Twitter: @betweenbrain
Github: https://github.com/betweenbrain

Sent from mobile. Please excuse any typos and brevity.
On Nov 11, 2013 1:04 PM, "davidhurley" notifications@github.com wrote:

Yep, exactly my thoughts.

Thanks,
David Hurley
On Nov 11, 2013 1:02 PM, "Nikolai Plath" notifications@github.com
wrote:

Well, since english is not my primary language, there may be different
understandings of "Power"... I'm sure we find something we all could
agree
on [image: 😉]


Reply to this email directly or view it on GitHub<
https://github.com/joomla/jissues/pull/179#issuecomment-28223510>
.


Reply to this email directly or view it on GitHubhttps://github.com//pull/179#issuecomment-28223641
.

@betweenbrain
Copy link
Contributor

Nikolai,

Thanks for bringing this up. This is an important thing to do.

Best,

Matt Thomas
Founder betweenbrain™
Lead Developer Construct Template Development Framework
Phone: 203.632.9322
Twitter: @betweenbrain
Github: https://github.com/betweenbrain

Sent from mobile. Please excuse any typos and brevity.
On Nov 11, 2013 1:17 PM, "Matt Thomas" matt@betweenbrain.com wrote:

Is there any precent of recognizing support for the project like this?

I would certainly like to see their contribution recognized appropriately.

Best,

Matt Thomas
Founder betweenbrain™
Lead Developer Construct Template Development Framework
Phone: 203.632.9322
Twitter: @betweenbrain
Github: https://github.com/betweenbrain

Sent from mobile. Please excuse any typos and brevity.
On Nov 11, 2013 1:04 PM, "davidhurley" notifications@github.com wrote:

Yep, exactly my thoughts.

Thanks,
David Hurley
On Nov 11, 2013 1:02 PM, "Nikolai Plath" notifications@github.com
wrote:

Well, since english is not my primary language, there may be different
understandings of "Power"... I'm sure we find something we all could
agree
on [image: 😉]


Reply to this email directly or view it on GitHub<
https://github.com/joomla/jissues/pull/179#issuecomment-28223510>
.


Reply to this email directly or view it on GitHubhttps://github.com//pull/179#issuecomment-28223641
.

@elkuku
Copy link
Contributor Author

elkuku commented Nov 11, 2013

From my personal point of view this is not so much about giving something back. In fact I am using my own (paid) license, even for my community contributions.

It's just to say:
PHPStorm is a great piece of software and we are using it extensively during the development of the JTracker Application.
aka "Powered by" - please find some appropriate (short) wording ;)

Edit: I have included this text in my original proposal to make it clearer.

@eddieajau
Copy link
Contributor

I totally agree with the initiative, but the "Powered by" is grating on me. If we can find a way to say "We just want to thank these people for what they've given to Joomla" succinctly, I'm all for it :)

@betweenbrain
Copy link
Contributor

I completely agree, and have also purchased my own license :-)

I am wondering if this extends beyond JIssues and to the project as a
whole? I personally have absolutely no problem with this, and recall that
others don't, but am also just recalling a previous thread about this on
list.

I'll see if I can dig that thread up.

Best,

Matt Thomas
Founder betweenbrain™
Lead Developer Construct Template Development Framework
Phone: 203.632.9322
Twitter: @betweenbrain
Github: https://github.com/betweenbrain

Sent from mobile. Please excuse any typos and brevity.
On Nov 11, 2013 3:19 PM, "Nikolai Plath" notifications@github.com wrote:

From my personal point of view this is not so much about giving something
back. In fact I am using my own (paid) license, even for my community
contributions.

It's just to say:
PHPStorm is a great piece of software and we are using it extensively
during the development of the JTracker Application.

aka "Powered by" - please find some appropriate (short) wording ;)


Reply to this email directly or view it on GitHubhttps://github.com//pull/179#issuecomment-28234915
.

@wilsonge
Copy link
Contributor

I agree but there's bugger all chance of me buying my own license 😆

@eddieajau
Copy link
Contributor

I agree but there's bugger all chance of me buying my own license

You don't have to if you are only using it for project work. If you are using it for code from which you derive an income, you are required to buy your own license, and rightly so.

@wilsonge
Copy link
Contributor

I know - that's why I haven't bought it ;)

@eddieajau
Copy link
Contributor

And that's perfectly ok. I didn't mean to sound like you weren't using it properly, sorry.

@javigomez
Copy link
Contributor

I started using it for Joomla and I also end up buying my license. PhpStorm rocks!

@@ -16,6 +16,7 @@
<li><a href="http://www.joomla.org/accessibility-statement.html">{{ "Accessibility Statement"|_ }}</a></li>
<li><a href="http://www.joomla.org/privacy-policy.html">{{ "Privacy Policy"|_ }}</a></li>
<li><a href="http://www.rochenhost.com/joomla-hosting" target="_blank">{{ "Joomla Hosting by"|_ }} Rochen Ltd.</a></li>
<li><a href="http://www.jetbrains.com/phpstorm/" target="_blank">{{ "Powered by %s"|_|format('PHPStorm') }}</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "Special thanks to %s" and we can leave the option open to add others.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a long list then :P

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm, maybe, but whatever. Ok, how about an end result of:

Accessibility Statement * Privacy Policy * Built on Rochen Hosting, PHPStorm

shrug

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, hang it, why not just change it to Powered by Rochen Hosting, PHPStorm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we back to Powered by? ;) Personally I like Built on here:
Powered by Rochen Hosting
Built on PHPStorm

@AmyStephen
Copy link

Please take my comment for what it's worth (not a lot), but I really dislike any advertising in the footer of every single page. It puts a target on the back of the contributor (Why is XYZ recognized and so and so is not?) Furthermore, there is no open and transparent process for community to provide feedback on these decisions.

It can sometimes be better to acknowledge the gift using a community blog post about the benefits the gift provides the community and the communities appreciation of the gift. That way, those sharing are recognized and valued, those reading who have something to share are encouraged to do so, and the same reward can be consistently applied as frequently, as needed.

Again, not suggesting my thinking on this is "right" since there is no right way to do it, just food for thought.

@eddieajau
Copy link
Contributor

Furthermore, there is no open and transparent process for community to provide feedback on these decisions.

Just an observation but this PR is an open and transparent process for the community to provide feedback on this proposal :) The point being made though is has the donation from JetBrains made a difference to building this application. If so, then why not acknowledge it. It's paying it forward.

@mbabker
Copy link
Contributor

mbabker commented Nov 14, 2013

I wouldn't be opposed to some sort of credits page, or finding a way to slip PhpStorm onto the Dependencies doc. But there is some validity in the argument about the footer link IMO.

@betweenbrain
Copy link
Contributor

I was thinking the same @mbabker

@eddieajau
Copy link
Contributor

Maybe park it until we get time to do the gamification, and we can give
JetBrains a special badge along with other people that have helped make the
application a success?

@brianteeman
Copy link
Contributor

At one point in our history they would have been listed here http://www.joomla.org/about-joomla/the-project/partners.html
You may blame the J!Tracker Application for transmitting this comment.

@Chris-Jones-Gill
Copy link

I think a 'supported by / thanks to / whatever' page is better than having things like this in every page footer.
It is more flexible, and easier to add more if necessary (Rochen for example) while still giving credit where it's due.
It also allows for more than a 1 line link, there can be a mini-article explaining what they have provided and who to contact for more information.
You can add features, such as the gamification badge(s), to it later.

@elkuku
Copy link
Contributor Author

elkuku commented Nov 14, 2013

Well, a footer link is kind of expensive I guess... Rochen should at least provide free hosting for all the Joomla! "Core" sites.. and more.

@mbabker's suggestion to include it in the dependencies page made me 😉 at first, but seems to be a good option to "solve" this. Not really sure if "Depends on" is better than "Powered by" - anyway.. under "Installed version" we would display then the version that every dev has installed - I use the http://confluence.jetbrains.com/display/PhpStorm/PhpStorm+Early+Access+Program btw 😉

@elkuku elkuku merged commit 632eb83 into framework Nov 17, 2013
@elkuku elkuku mentioned this pull request Nov 17, 2013
@elkuku
Copy link
Contributor Author

elkuku commented Nov 17, 2013

Just to avoid confusion... this has not been merged, I tried to modify my original proposal, but GitHub was too intelligent.. so ⇒ #223

@elkuku elkuku mentioned this pull request Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet