Project bot + github factory Fix #337 #383 #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GitHubFactory-merge-1 Conflicts: src/App/Tracker/Model/IssueModel.php
|
Well :) How do we test it? |
Create some GitHub project, some accounts, and test with your local installation 😉 |
elkuku
changed the title
|
I did some testing before and after the merge - it looks like this: jtester/tests#26 |
Fix misspelled namespace GitHub vs Github
|
Looks pretty good :) Seems like we can merge it 😄 |
|
@mbabker I think we need to create a bot account before we merge it? |
|
Already have @jissues-bot at our service. Do we need more? |
|
:D ok I am merging. Do not forget about DB updates ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines #337 and #383