[com_finder] filters view: searchtools ordering, bug corrections and some improvements

[andrepereiradasilva]

Summary of Changes

This PR by adding the ordering normalizes the searchtools in com_finder filters view.

Also:

• Corrects some minor bugs
• Some code style improvements.

Before PR

After PR

Testing Instructions

1. Use latest staging and apply patch
2. Go to Components -> Smart Search -> Filters
3. Create some filters
4. Test if search, filters, ordering and page limit (aka searchtools) are working properly.

[joomla-cms-bot]

This PR has received new commits.

CC: @andrepereiradasilva

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10029.}

[joomla-cms-bot]

This PR has received new commits.

CC: @andrepereiradasilva

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10029.}

[brianteeman]

Would it not be consistent to move the message that Smart Search content plugin is not enabled to above the filters?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10029.}

[andrepereiradasilva]

yes it will and it will be done in another PR.
this PR is only for the smart search filters view (Smart Search: Search Filters).

[brianteeman]

OK I thought in the past you did it as a single PR. My mistake.

[andrepereiradasilva]

no smart search has many things to correct. i will do one PR for each view.

[brianteeman]

I have tested this item ✅ successfully on 2b4ceb2

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10029.}

[joomla-cms-bot]

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10029.}

[andrepereiradasilva]

@brianteeman just corrected a state filter problem. wasn't working properly in hathor. See (9855e85)

To test this change just test the "state" filter in isis and in hathor.

I found similar problem in other filters in hathor. will make a PR to solve them.

[brianteeman]

Is it related to #6578

[andrepereiradasilva]

no, not related.

This is because the filter input is too restrictive. 'int' doesn't allow empty values, only int. The same problem in happing to languages. All is *, but the input filter is cmd that doesn't allow *.

See here https://github.com/joomla/joomla-cms/blob/staging/libraries/vendor/joomla/filter/src/InputFilter.php#L147-164

As said i will make a PR to correct them.

[brianteeman]

OK - I was hoping it was and we could kill two birds with one PR

[grhcj]

I have tested this item ✅ successfully on 9855e85

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10029.}

[andrepereiradasilva]

@brianteeman @grhcj thanks for testing!

[brianteeman]

I have tested this item ✅ successfully on 9855e85

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10029.}

[brianteeman]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10029.}