Copy template modal missing tip

[infograf768]

Edit a template (not a template style). Click on Copy Template toolbar button. No tip.
Patch.
Result should be:

[brianteeman]

I have tested this item ✅ successfully on 735666f

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10071.}

[alikon]

I have tested this item ✅ successfully on 735666f

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10071.}

[brianteeman]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10071.}

[cyrezdev]

Why the span 6 ?

[cyrezdev]

@infograf768 The span6 gives trouble for the label, not vertically aligned with the input.
I have commented your code, as with a simple div control-label to include the label, it solves this display issue ;-)

[infograf768]

I added the span6 because of the position of the tip.
If I follow you (as far as I understand) and change to:

<div id="template-manager-css" class="form-horizontal">
    <div class="control-label">
        <label for="new_name" class="modalTooltip" title="<?php echo JHtml::_('tooltipText', 'COM_TEMPLATES_TEMPLATE_NEW_NAME_LABEL', 'COM_TEMPLATES_TEMPLATE_NEW_NAME_DESC'); ?>">
            <?php echo JText::_('COM_TEMPLATES_TEMPLATE_NEW_NAME_LABEL')?>
        </label>
    </div>
    <div class="controls">
        <input class="input-xlarge" type="text" id="new_name" name="new_name"  />
    </div>
</div>

then I get:

[infograf768]

BTW, the tip here is now displayed in the same position as in Batch modals, where it does so grace to the span6.

[cyrezdev]

@infograf768 ok i understand your intention ;-)
But my proposal was not exactly has you supposed, but using bootstrap standard form field structure like this :

<div id="template-manager-css" class="form-horizontal">
    <div class="control-group">
        <div class="control-label">
            <label for="new_name" class="modalTooltip" title="<?php echo JHtml::_('tooltipText', 'COM_TEMPLATES_TEMPLATE_NEW_NAME_LABEL', 'COM_TEMPLATES_TEMPLATE_NEW_NAME_DESC'); ?>">
                <?php echo JText::_('COM_TEMPLATES_TEMPLATE_NEW_NAME_LABEL')?>
            </label>
        </div>
        <div class="controls">
            <input class="input-xlarge" type="text" id="new_name" name="new_name"  />
        </div>
    </div>
 </div>

If you want same display as inside batch (which is loaded field from layout and not constructing it as in copy modal) so you should not use form-horizontal.

There the code with exactly the batch modal rendering :

<div id="template-manager-css" class="row-fluid">
    <div class="control-group span6">
        <div class="controls">
            <label for="new_name" class="control-label modalTooltip" title="<?php echo JHtml::tooltipText('COM_TEMPLATES_TEMPLATE_NEW_NAME_DESC'); ?>"><?php echo JText::_('COM_TEMPLATES_TEMPLATE_NEW_NAME_LABEL')?></label>
            <input class="input-xlarge" type="text" id="new_name" name="new_name"  />
        </div>
    </div>
</div>

But the good BS2 way seems using fieldset for this display: http://getbootstrap.com/2.3.2/base-css.html#forms

@infograf768 as your PR is already merged, no need to revert it, as i've planned to change name of modal id (which should be unique) from collapseModal to copyModal and so be logical with other modals of this view (renameModal, fileModal, folderModal...) so i could do the change in the same time! ;-)

So, what's best ?

• Batch look like (with span6)
• Or Bootstrap form field look like (as for all edit forms)

Note: my screenshots are on a big screen, so that's why very large modals... and i can do an adjustement in the same time of the PR with new file names ;-)

[infograf768]

@JoomliC
Cyril, I honestly don't care, as long as tips are readable and interface is consistent. 😃

[cyrezdev]

@infograf768 👍
I will check it to improve it, and in the same time, display hidden tooltip in some othe modals of this view (the more i work on modals, the more i see minor issues, so good to fix them all... but consistency is not easy as some modals loading iframe, some layouts for fields, and some (as here) built in view fields...)
Will inform there when PR will be ready ;-)

[cyrezdev]

@infograf768 just created the PR #10100 with a few improvement not only for tooltip, but too for usuability of file and folder modals ;-)