Contact options - showon #10153
Merged
Contact options - showon #10153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on 4db2490 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10153. |
1 similar comment
|
I have tested this item ✅ successfully on 4db2490 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10153. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10153. |
| @@ -253,7 +255,7 @@ | |||
| type="list" | |||
| default="10" | |||
| label="COM_CONTACT_FIELD_ARTICLES_DISPLAY_NUM_LABEL" | |||
| description="COM_CONTACT_FIELD_ARTICLES_DISPLAY_NUM_DESC" | |||
There was a problem hiding this comment.
why remove the description?
|
This PR has received new commits. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10153. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Use the showon functionality now available in forms to simplify/reduce the options displayed in the com_contact component options
Testing Instructions
This is only a cosmetic change
Go to the Options page for this component and try all the options on that page to ensure that the new show/hide functionality makes sense.
[Note this is part of a series of PR for each component options page and then the menu options]