Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_finder] index view: Add content map filter #10256

Merged

Conversation

andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented May 5, 2016

Pull Request for Improvement.

Summary of Changes

This PR adds a new filter to the com_finder (smart search) index view.

image

Testing Instructions

  1. Apply patch
  2. Go to Smart Search -> Indexed Content and test the new filter.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels May 5, 2016
@andrepereiradasilva andrepereiradasilva changed the title [com_finder] Add content map filter [com_finder] index view: Add content map filter May 5, 2016
@chrisdavenport
Copy link
Contributor

How does the drop-down perform when you have hundreds of options in it?

@brianteeman
Copy link
Contributor

Probably quite badly based on the previous performance issues with a chosen select

@andrepereiradasilva
Copy link
Contributor Author

andrepereiradasilva commented May 5, 2016

@chrisdavenport to be honest just tested with joomla sample data index (46 items in content maps) with no notice change in page speed rendering.

Will try to test tomorrow with more items.

@andrepereiradasilva
Copy link
Contributor Author

andrepereiradasilva commented May 6, 2016

just tested with a random generated 5000 items content map! 200ms difference. Also a bit of 100ms opening the filter. The search is instant. I'm simulating a huge 5000 content map tree...

I don't have a huge search index database to test more properly. @chrisdavenport do you have it?

@andrepereiradasilva
Copy link
Contributor Author

andrepereiradasilva commented May 6, 2016

we could also do as the frontend and add the same filters the frontend have, instead of a all in one content map filter. (types are already there, so author, category and language). But i'm not sure about this, because for what i understand the level 1 branches are dynamic.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on a10733e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10256.

@zero-24
Copy link
Contributor

zero-24 commented May 8, 2016

I have tested this item ✅ successfully on a10733e

looks good to me. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10256.

@zero-24
Copy link
Contributor

zero-24 commented May 8, 2016

Works and look good now -> RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10256.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 8, 2016
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 8, 2016
@Kubik-Rubik
Copy link
Member

Thank you @andrepereiradasilva and testers!

@Kubik-Rubik Kubik-Rubik merged commit 1a282ab into joomla:staging May 8, 2016
@andrepereiradasilva andrepereiradasilva deleted the com_finder_branch_filter branch May 8, 2016 14:11
@zero-24
Copy link
Contributor

zero-24 commented May 11, 2016

please remove the label @joomla-cms-bot

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants