-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[com_finder] index view: Add content map filter #10256
[com_finder] index view: Add content map filter #10256
Conversation
How does the drop-down perform when you have hundreds of options in it? |
Probably quite badly based on the previous performance issues with a chosen select |
@chrisdavenport to be honest just tested with joomla sample data index (46 items in content maps) with no notice change in page speed rendering. Will try to test tomorrow with more items. |
just tested with a random generated 5000 items content map! 200ms difference. Also a bit of 100ms opening the filter. The search is instant. I'm simulating a huge 5000 content map tree... I don't have a huge search index database to test more properly. @chrisdavenport do you have it? |
we could also do as the frontend and add the same filters the frontend have, instead of a all in one content map filter. (types are already there, so author, category and language). But i'm not sure about this, because for what i understand the level 1 branches are dynamic. |
I have tested this item ✅ successfully on a10733e This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10256. |
I have tested this item ✅ successfully on a10733e This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10256. |
Works and look good now -> RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10256. |
Thank you @andrepereiradasilva and testers! |
please remove the label @joomla-cms-bot |
Pull Request for Improvement.
Summary of Changes
This PR adds a new filter to the com_finder (smart search) index view.
Testing Instructions