New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[com_finder] maps view: Indexed content counting and other improvements #10257
[com_finder] maps view: Indexed content counting and other improvements #10257
Conversation
I have tested this item 🔴 unsuccessfully on e19edeb This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10257. |
ok will check that. |
…inder_maps-improvements
This PR has received new commits. CC: @grhcj This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10257. |
This PR has received new commits. CC: @grhcj This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10257. |
This PR has received new commits. CC: @grhcj This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10257. |
This PR has received new commits. CC: @grhcj This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10257. |
ok should be fixed now. |
This PR has received new commits. CC: @grhcj This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10257. |
@grhcj please retest |
I have tested this item ✅ successfully on ed45c32 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10257. |
thsnk for testing, yes that will only work with #10256 also applied |
I have tested this item ✅ successfully on ed45c32 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10257. |
RTC -before merging please double check the unrelated Travis issue This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10257. |
Travis is unrelated and now fixed in staging. Merging this |
thanks for testing, comments and merging! |
Pull Request for Improvement.
Summary of Changes
This PR adds some improvements to Smart Search Content Maps:
Before PR
After PR
Testing Instructions
3 simple test needed.
Apply patch
Go to Smart Search -> Indexed Content and run the index
Go to Smart Search -> Content Maps
Click on a content map "Title" and check that in that row the select box is checked.
ok = test 1 passed
Click on the blue level 1 badge. and confirm it showns only the sublevels after click. Clear the filter after.
ok = test 2 passed
Confirm the published/unpublished counting is working properly and they link to the index content view with the corresponding filter.
Please note that the content_map will only be activated if PR [com_finder] index view: Add content map filter #10256 is also installed, but you can check the resulting URL (check the filter is there) for this test propose.
ok = test 3 passed