SimplePie Update Incomplete Fixes #10280 #10285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,2 @@ | |||
| DELETE FROM `#__extensions` WHERE `type` = 'library' AND `element` = 'simplepie'; | |||
| DELETE FROM `#__extensions` WHERE `type` = 'library' AND `element` = 'phpmailer'; | |||
There was a problem hiding this comment.
You don't need PHPMailer here, it was removed by ID with https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/sql/updates/mysql/3.4.0-2014-10-20.sql (and the corresponding files for the non-MySQL engines)
There was a problem hiding this comment.
Thanks just fixed with: e6b85f7 i have not noticed that as i have searched for the string phpmailer ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #10280
Summary of Changes
Removal of the SimplePie library extension from the database (new install and update)
Removal of the SimplePie library extension's manifest
Deleting libraries/simplepie on update
run the delete query for phpmailer too
Testing Instructions
@mbabker @wilsonge please have a look.