Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct sendmail path (Fix #10032) #10342

Merged
merged 1 commit into from
May 10, 2016
Merged

Set correct sendmail path (Fix #10032) #10342

merged 1 commit into from
May 10, 2016

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented May 8, 2016

Pull Request for Issue #10032

Summary of Changes

Overrides the PHPMailer::isSendmail() method to remove the restriction on the name of the sendmail binary's name and to read the sendmail path configured in the global configuration (defaulting to PHP's sendmail_path if something isn't set in the global config and ultimately defaulting to /usr/sbin/sendmail if neither of those give a path).

Testing Instructions

Set a custom sendmail path in the global config, send a message using it, and ensure PHPMailer uses the correct binary path.

@andrepereiradasilva
Copy link
Contributor

tested with sucess!

Used /sbin/sendmail as sendmail binary path.

And used "Send Test mail" button with the Mailer set to "Sendmail"

Before patch
image

After patch
image

The "error" is because the usage of escapeshellarg is not allowed on the server.
But for this test is enough.

@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on 669eb90


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10342.

@zero-24
Copy link
Contributor

zero-24 commented May 10, 2016

I have tested this item ✅ successfully on 669eb90

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10342.

@zero-24
Copy link
Contributor

zero-24 commented May 10, 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10342.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 10, 2016
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 10, 2016
@wilsonge wilsonge merged commit caab0bb into joomla:staging May 10, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 10, 2016
@mbabker mbabker deleted the JMail-isSendmail-override branch May 10, 2016 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants