New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[com_config] Fallback warning in send test mail (solves #9680) #10370
[com_config] Fallback warning in send test mail (solves #9680) #10370
Conversation
I have tested this item ✅ successfully on a90a531 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370. |
@brianteeman since you also add the original issue, can you test this one? |
@brianteeman can i ask you to please test this one? |
I would test it if I could recreate the scenario now but i cant This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370. |
ok @brianteeman thanks anyway. |
Hello, I have tested this on Joomla! 3.6.0-alpha2-dev staging. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370. |
Unfortunately I am also not able to reproduce this issue before applying patch. I have followed instructions in the main issue. Like giving wrong port and wrong host but still not getting green message. Is there any other possible way to reproduce it? Thanks. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370. |
Set smtp authentication to yes, with user and password empty |
Thanks @andrepereiradasilva Follow your comments, but still having the same and not able to reproduce it before applying patch. I am using latest staging branch with smtp authentication to yes, with user and password empty. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370. |
what error do you have with the last test case? Maybe you don't have php mailer working so there is not fallback. |
I am getting the same error which @AnishaVora is getting. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370. |
so your SMTP fails and your fallback also fails. To test this you have to php Probably you don't have a correct sendmail path in your server. |
Hello, This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370. |
I have tested this item ✅ successfully on a90a531 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370. |
nice thanks! |
@brianteeman RTC? |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370. |
I can also confirm the test successful as I was there while Anisha was testing this issue on her machine. 😄 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370. |
Conflicts please :) |
This PR has received new commits. CC: @AnishaVora, @zero-24 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370. |
conflicts fixed |
This PR has received new commits. CC: @AnishaVora, @zero-24 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370. |
sorry for this late one, just one thing lost in the conflixcts fix |
It's ok :) Thanks for getting on it so fast! |
Pull Request for Issue #9680.
Summary of Changes
Sometimes when sending a testmail the mail is sent even that you know the mail config is not correct.
This happens because JMail has some fallbacks (see, for instance, https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/mail/mail.php#L601-L627).
So this PR adds a fallback warning in global configuration "Send Test Mail" button result s users can notice that the mail is sent, but not with the configurations that the user chossed.
Before PR
After PR
Testing Instructions
I get the fallback message by using SMTP with SMTP Authentication and didn't type the SMTP Auth user or password (leave the fields empty). I this will not allow to connect to my SMTP server.