Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_config] Fallback warning in send test mail (solves #9680) #10370

Merged
merged 6 commits into from Jun 15, 2016

Conversation

andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented May 10, 2016

Pull Request for Issue #9680.

Summary of Changes

Sometimes when sending a testmail the mail is sent even that you know the mail config is not correct.

This happens because JMail has some fallbacks (see, for instance, https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/mail/mail.php#L601-L627).

So this PR adds a fallback warning in global configuration "Send Test Mail" button result s users can notice that the mail is sent, but not with the configurations that the user chossed.

Before PR
image

After PR
image

Testing Instructions

  1. Apply patch and go to global config
  2. Clear browser cache
  3. Test "Send Test Mail" with all possible mail configs you can remember.

I get the fallback message by using SMTP with SMTP Authentication and didn't type the SMTP Auth user or password (leave the fields empty). I this will not allow to connect to my SMTP server.
image

@zero-24
Copy link
Contributor

zero-24 commented May 10, 2016

I have tested this item ✅ successfully on a90a531

Works good. please remember on testing to clear your browser cache.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

@andrepereiradasilva
Copy link
Contributor Author

@brianteeman since you also add the original issue, can you test this one?

@andrepereiradasilva
Copy link
Contributor Author

@brianteeman can i ask you to please test this one?

@brianteeman
Copy link
Contributor

I would test it if I could recreate the scenario now but i cant


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

@andrepereiradasilva
Copy link
Contributor Author

ok @brianteeman thanks anyway.
anyone else can test this?

@AnishaTailored
Copy link

Hello,
I have tried with incorrect SMTP details (incorrect username and password) but I could not see the same message that you have shown in before PR section. Instead I am getting 'Test mail could not be sent.' and 'SMTP Error: Could not authenticate.'

I have tested this on Joomla! 3.6.0-alpha2-dev staging.
screen shot 2016-06-03 at 08 25 28


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

@gunjanpatel
Copy link
Contributor

Unfortunately I am also not able to reproduce this issue before applying patch. I have followed instructions in the main issue. Like giving wrong port and wrong host but still not getting green message. Is there any other possible way to reproduce it?

Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

@andrepereiradasilva
Copy link
Contributor Author

Unfortunately I am also not able to reproduce this issue before applying patch. I have followed instructions in the main issue. Like giving wrong port and wrong host but still not getting green message. Is there any other possible way to reproduce it?

Set smtp authentication to yes, with user and password empty

@gunjanpatel
Copy link
Contributor

Thanks @andrepereiradasilva Follow your comments, but still having the same and not able to reproduce it before applying patch. I am using latest staging branch with smtp authentication to yes, with user and password empty.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

@andrepereiradasilva
Copy link
Contributor Author

what error do you have with the last test case? Maybe you don't have php mailer working so there is not fallback.

@gunjanpatel
Copy link
Contributor

I am getting the same error which @AnishaVora is getting.

screen shot 2016-06-06 at 08 05 21


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

@andrepereiradasilva
Copy link
Contributor Author

so your SMTP fails and your fallback also fails.

To test this you have to php mail function working properly to have a fallback in case SMTP does not work.

Probably you don't have a correct sendmail path in your server.
Check if your php ini sendmail_path is correct: http://php.net/manual/en/mail.configuration.php#ini.sendmail-path

@AnishaTailored
Copy link

Hello,
I have tested this successfully with empty SMTP username and password (re-tested after installing sendmail). After applying the patch the following message is displayed.
screen shot 2016-06-08 at 05 20 00


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

@AnishaTailored
Copy link

I have tested this item ✅ successfully on a90a531


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

@andrepereiradasilva
Copy link
Contributor Author

nice thanks!

@andrepereiradasilva
Copy link
Contributor Author

@brianteeman RTC?

@gunjanpatel
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 8, 2016
@gunjanpatel
Copy link
Contributor

I can also confirm the test successful as I was there while Anisha was testing this issue on her machine. 😄


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

@wilsonge
Copy link
Contributor

Conflicts please :)

@wilsonge wilsonge added this to the Joomla 3.6.0 milestone Jun 15, 2016
@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @AnishaVora, @zero-24


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

@andrepereiradasilva
Copy link
Contributor Author

conflicts fixed

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @AnishaVora, @zero-24


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

@andrepereiradasilva
Copy link
Contributor Author

sorry for this late one, just one thing lost in the conflixcts fix
c41292d

@wilsonge wilsonge merged commit abc6f9b into joomla:staging Jun 15, 2016
@wilsonge
Copy link
Contributor

It's ok :) Thanks for getting on it so fast!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 15, 2016
@andrepereiradasilva andrepereiradasilva deleted the sendmail-fallback branch June 15, 2016 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants