Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mod_search] Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8') #10405

Merged
merged 1 commit into from
May 16, 2016

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented May 11, 2016

Pull Request for Issue #10399 .

Summary of Changes

Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8')

Testing Instructions

  • Enable the mod_search module to the frontend
  • see that it works
  • apply this patch
  • see that it still works

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 95c256d


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10405.

@infograf768
Copy link
Member

Any reason (in this PR as well as in other similar PRs) to not use ENT_QUOTES instead of ENT_COMPAT.
ENT_QUOTES would also take care of single quotes.

@Bakual
Copy link
Contributor

Bakual commented May 12, 2016

ENT_COMPAT is the default case for the method. So no functionality changes here this way. If it worked before, it will still work afterwards.
It's just the added encoding that is important here.

@BurtNL
Copy link
Contributor

BurtNL commented May 12, 2016

I have tested this item ✅ successfully on 95c256d


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10405.

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10405.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 12, 2016
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 12, 2016
@rdeutz rdeutz merged commit ad475a7 into joomla:staging May 16, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 16, 2016
@zero-24 zero-24 deleted the patch-15 branch May 16, 2016 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants