Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Style #10454

Merged
merged 1 commit into from
May 25, 2016
Merged

Code Style #10454

merged 1 commit into from
May 25, 2016

Conversation

photodude
Copy link
Contributor

@photodude photodude commented May 13, 2016

Pull Request for Code Style improvements .

Summary of Changes

  • When splitting array definitions onto several lines, the last value should also have a trailing comma.
  • Broke a few lines into multiline just for easier reading.

Testing Instructions

Can be merged by code review.

Testing if desired would be to apply the patch and then check that the system info panel works as expected in admin

- When splitting array definitions onto several lines, the last value should also have a trailing comma.
- Broke a few lines into multiline just for easier reading.
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on c473205

tested component still works


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10454.

@zero-24
Copy link
Contributor

zero-24 commented May 24, 2016

I have not tested this item.

Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10454.

@zero-24
Copy link
Contributor

zero-24 commented May 24, 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10454.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 24, 2016
@brianteeman
Copy link
Contributor

brianteeman commented May 24, 2016 via email

@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 24, 2016
@zero-24
Copy link
Contributor

zero-24 commented May 25, 2016

I have tested this item ✅ successfully on c473205

lol. Thanks @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10454.

@roland-d roland-d merged commit 89fde17 into joomla:staging May 25, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 25, 2016
@roland-d
Copy link
Contributor

Thanks everybody

@photodude photodude deleted the patch-4 branch May 25, 2016 20:10
@photodude
Copy link
Contributor Author

Thanks everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants