Make including pw in mail to user optional when created by admin #10462
Conversation
…nistrator. When creating user accounts as administrator and sending an email, it is now optional to include the password in the mail. This is configurable on the plugin. Sending the email was already optional. When sending emails, including the password in the email is now optional. This closes issue joomla#10376
|
@sovainfo see sovainfo#3 |
| @@ -8,11 +8,14 @@ PLG_USER_JOOMLA_FIELD_AUTOREGISTER_DESC="Automatically create Registered Users w | |||
| PLG_USER_JOOMLA_FIELD_AUTOREGISTER_LABEL="Auto-create Users" | |||
| PLG_USER_JOOMLA_FIELD_FORCELOGOUT_DESC="Set to No to disable this." | |||
| PLG_USER_JOOMLA_FIELD_FORCELOGOUT_LABEL="Force Logout for all Sessions?" | |||
| PLG_USER_JOOMLA_FIELD_INCLUDEPASSWORD_DESC="Inlude the password when sending a mail to the created user." | |||
There was a problem hiding this comment.
"Include password in the email sent to the created user."?
CS fix, thanks @wojsmol
|
Thank you, @wojsmol @andrepereiradasilva |
|
I have tested this item ✅ successfully on dd4e457 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10462. |
|
I dont understand why you did it this way in the plugin and didnt use the existing option This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10462. |
|
Disagree on using the option meant for the registration process. The registration process is different from the account creation process by an administrator. Consider that you should be able to configure that setting for each process. The settings can be the same or different. Setting it for one process has no bearing on the other. That is the functionality I think should be provided. |
|
I agree this should be done in the plugin as it is already there that sending mail is defined. |
|
This PR has received new commits. CC: @BurtNL This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10462. |
|
This PR has received new commits. CC: @BurtNL This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10462. |
|
Tried to fix the conflicts but apparently failed:
Maybe somebody else has more luck! |
|
@wojsmol Thanks for trying to help. Using GitHub for Firefox exclusively, haven't found proper way to resolve conflicts, revert or rebase. The only way I know is to close and create a new PR. Very disappointing if that is what needs to be done. Will wait for feedback before giving up and closing! |
|
@sovainfo See staging...wojsmol:10462-rebase - current staging with thIs PR. |
|
@wojsmol Thanks, but neither of them help. The procedure is incorrect and can't do anything with the rebase you are pointing to! Unbelievable for a product that is supposed to make these things easier! |
|
@sovainfo Is this PR to be redone or can you fix the conflicts? |
|
Can't fix the conflicts! |
|
@sovainfo Are you planning redo this PR based on the current staging? |
|
Yes, probably after the release of J360. |
|
Please see #10990 |
Pull Request for Issue #10376 .
Summary of Changes
When creating user accounts as administrator and sending an email, it is now optional to include the password in the mail.
This is configurable on the plugin. Sending the email was already optional.
When sending emails, including the password in the email is now optional.
Testing Instructions
Apply this patch
As administrator create an user account.
Verify that the password is included in the mail.
Configure plugin User - Joomla to exlude the password.
Create an user account.
Verify that the password in not in the mail.
This closes issue #10376