[plg_system_sef] Add sef URI when using srcset attribute #10464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -107,7 +107,7 @@ public function onAfterRender() | |||
|
|
|||
| // Check for all unknown protocals (a protocol must contain at least one alpahnumeric character followed by a ":"). | |||
| $protocols = '[a-zA-Z0-9\-]+:'; | |||
| $attributes = array('href=', 'src=', 'poster='); | |||
| $attributes = array('href=', 'src=', 'srcset=', 'poster='); | |||
| foreach ($attributes as $attribute) | |||
| { | |||
There was a problem hiding this comment.
Can you add a clean line bevor the foreach?
|
@zero-24 this PR is not for code style of the SEF plugin ... |
|
I have tested this item ✅ successfully on 8474310 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10464. |
|
I have tested this item ✅ successfully on 8474310 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10464. |
|
RTC. Thanks This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10464. |
|
for 3.6.0 I guess. |
|
Thanks everybody |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #10463.
Summary of Changes
See #10463
Testing Instructions
/images/sampledata/parks/banner_cradle.jpgor/<sitepath>/images/sampledata/parks/banner_cradle.jpg)Please note this will not solve all
srcsetpossibilities, only for cases like the one described in the issue (path to one image).