Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onContentPrepare event in contact view to trigger on correct text #10541

Merged
merged 1 commit into from
May 23, 2016

Conversation

ggppdk
Copy link
Contributor

@ggppdk ggppdk commented May 18, 2016

Issue

The onContentPrepare event triggering on the contact view has no effect

Summary of Changes

Trigger onContentPrepare event on proper property ($item->misc)

Testing Instructions

  1. Edit a contact
  2. Go to "Miscellaneous Information" TAB
  3. Add plugin text of some content plugin that does not limit itself into some specific component / view
  4. View the contact in frontend , the plugin text is replaced ...

Issue:
the onContentPrepare event triggering on the view has no effect

Instructions:
1. Edit a contact
2. Go to "Miscellaneous Information" TAB
3. Add plugin text of some content plugin that does not limit itself into some specific component / view
4. View the contact in frontend , the plugin text is replaced ...
@andrepereiradasilva
Copy link
Contributor

"Add plugin text of some content plugin that does not limit itself into some specific component / view"

can you provide examples of this?

@ggppdk
Copy link
Contributor Author

ggppdk commented May 18, 2016

Thanks, an example, add these 2 cases

  • text for content/loadmodule.php plugin
  • text for content/emailcloak.php plugin
{loadmodule mod_banners,Banners}
sometest@sometestdom.com

You will see that
1 . the banner module gets added (or at least it disappears, if module is not found)
2 . the email gets cloaked (becomes a link, and if you examine the HTML you will see the cloaking code)

@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on 7fc838a

Works as described.

BTW can you similar PR also for the cases described in #10539 (tags, etc)?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10541.

@ghazal
Copy link
Contributor

ghazal commented May 22, 2016

I have tested this item ✅ successfully on 7fc838a

I am kind of relieved that you found a working solution.
I was the one who pointed the bug out.
But I think the feature is useful and it would have been a pity to remove it.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10541.

@ggppdk
Copy link
Contributor Author

ggppdk commented May 22, 2016

@andrepereiradasilva , @ghazal

thanks for testing

Now about:

BTW can you similar PR also for the cases described in #10539 (tags, etc)?

For tags view, the content plugin triggering is already working well in both

  • description of the tag
  • description of the articles

so there is nothing to fix at list in for tags view

@andrepereiradasilva
Copy link
Contributor

did you tried /component/tags/ url?

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10541.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 23, 2016
@brianteeman brianteeman modified the milestone: Joomla 3.6.0 May 23, 2016
@roland-d roland-d merged commit 0a98dbe into joomla:staging May 23, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 23, 2016
@roland-d
Copy link
Contributor

Thanks everybody

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants