Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com_installer. Remove button update.purge #10644

Closed
wants to merge 1 commit into from
Closed

com_installer. Remove button update.purge #10644

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented May 27, 2016

Summary of Changes

In view
administrator/index.php?option=com_installer&view=update
we don't need the button Clear Cache (purge()) because button Find Updates always calls the purge() method, too.
This PR removes button Clear Cache.

Testing Instructions

Hm, that's a problem. I don't know how to provide instructions before/after because both buttons work correctly but button Find Updates is sufficient because it includes a Clear Cache.

Button Find Updates calls
controllers/update.php::find()

that's calling
$model->findUpdates(...)
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_installer/controllers/update.php#L106

that's always calling the purge()-method.
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_installer/models/update.php#L255-L258

@brianteeman
Copy link
Contributor

I cant find it now but I seem to recall a big debate in the past over this


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10644.

@zero-24
Copy link
Contributor

zero-24 commented May 27, 2016

@brianteeman @bertmert #3775 and 389374f

@brianteeman
Copy link
Contributor

yes thats the one

@ghost
Copy link
Author

ghost commented May 27, 2016

The arguments there are outdated or wrong concerning cache times and so on or I don't understand the higher philosophy behind that discussion CONCERNING THESE BUTTONS (please tell me).

Joomla 3.5.1 and current staging: Fact is: When you click on Find Updates a complete purge is always done in the same way as when you just click on Clear Cache.

Why should I click just Clear Cache? To see an empty list? Then click on Find Updates to do a second purge that's done already?

@ghost ghost closed this Jun 1, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants