com_installer. Remove button update.purge #10644
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
In view
administrator/index.php?option=com_installer&view=update
we don't need the button Clear Cache (purge()) because button Find Updates always calls the purge() method, too.
This PR removes button Clear Cache.
Testing Instructions
Hm, that's a problem. I don't know how to provide instructions before/after because both buttons work correctly but button Find Updates is sufficient because it includes a Clear Cache.
Button Find Updates calls
controllers/update.php::find()
that's calling
$model->findUpdates(...)
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_installer/controllers/update.php#L106
that's always calling the purge()-method.
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_installer/models/update.php#L255-L258