[FIX 3.6.0-alpha] Do not close edit modal when escape key is pressed (Thanks @andrepereiradasilva !) #10667
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue comment #10654 (comment).
cc/ @andrepereiradasilva
Summary of Changes
close
,Save & Close
andSave
buttons, but it was still possible to close with escape key.Testing Instructions
To be tested on 3.6.0-alpha or latest staging!
This could be tested for those modals (test that you can't close modal with escape key):
modules
andAdd a module for this menu
Single Article
Select article, save and then click onEdit
button to open Edit modalCategory Blog
Select category, save and then click onEdit
button to open Edit modalSingle Contact
Select contact, save and then click onEdit
button to open Edit modalSingle Newsfeed
Select newsfeed, save and then click onEdit
button to open Edit modalarticle
,category
,newsfeed
,contact
in associations tab for each item should have the same behavior.