Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX 3.6.0-alpha] Do not close edit modal when escape key is pressed (Thanks @andrepereiradasilva !) #10667

Conversation

cyrezdev
Copy link
Contributor

@cyrezdev cyrezdev commented May 29, 2016

Pull Request for Issue comment #10654 (comment).
cc/ @andrepereiradasilva

Summary of Changes

  • In already merged new edit modals, it was fixed to not allow closing of an edit modal on click (needed behavior for a clean item edit closing), to allow closing only on close, Save & Close and Save buttons, but it was still possible to close with escape key.
  • This PR disable the possibility to close the edit modal when escape key is pressed
  • A few ordering changes of modal params, to be consistend with the modal main jlayout

Testing Instructions

To be tested on 3.6.0-alpha or latest staging!
This could be tested for those modals (test that you can't close modal with escape key):

  • Menus > Manage : button to edit modules and Add a module for this menu
  • in all menu item edition : go to tab "Modules Assignment" and click on one of the modules name to open Edit modal.
  • Menus > Menu > Menu item with item type Single Article Select article, save and then click on Edit button to open Edit modal
  • Menus > Menu > Menu item with item type Category Blog Select category, save and then click on Edit button to open Edit modal
  • Menus > Menu > Menu item with item type Single Contact Select contact, save and then click on Edit button to open Edit modal
  • Menus > Menu > Menu item with item type Single Newsfeed Select newsfeed, save and then click on Edit button to open Edit modal
  • article, category, newsfeed, contact in associations tab for each item should have the same behavior.

+ minor constituency changes according to modal main layout
+ minor changes for array params consistency
+ consistency order for array of params with modal main layout
+ consistency ordering for array of params with modal main layout
@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on a1d1b06

Works fine! thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10667.

@BurtNL
Copy link
Contributor

BurtNL commented May 29, 2016

I have tested this item ✅ successfully on a1d1b06

Works as described


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10667.

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10667.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 29, 2016
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 29, 2016
@wilsonge wilsonge merged commit e9972a7 into joomla:staging May 30, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants