Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change unit test logger's log path #10849

Merged
merged 1 commit into from
Jul 20, 2016
Merged

Change unit test logger's log path #10849

merged 1 commit into from
Jul 20, 2016

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Jun 17, 2016

Summary of Changes

Change the path that the unit test logging helper logs to from the old root logs directory to tests/unit/tmp

Testing Instructions

Review

@csthomas
Copy link
Contributor

Is the title correct?

@andrepereiradasilva
Copy link
Contributor

@mbabker seems the title of this PR is not correct.

@mbabker mbabker changed the title Protect the database $name variable Change unit test logger's log path Jun 17, 2016
@mbabker
Copy link
Contributor Author

mbabker commented Jun 17, 2016

Fixed. Apparently I had a session collision with another idea I was testing out.

@mbabker
Copy link
Contributor Author

mbabker commented Jul 20, 2016

@wilsonge Merge this...

@zero-24
Copy link
Contributor

zero-24 commented Jul 20, 2016

@joomla-cms-bot


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10849.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 20, 2016
@wilsonge wilsonge merged commit 3dd50b4 into joomla:staging Jul 20, 2016
@wilsonge wilsonge added this to the Joomla 3.6.1 milestone Jul 20, 2016
@mbabker mbabker deleted the unit-test-logger branch July 20, 2016 14:51
@zero-24
Copy link
Contributor

zero-24 commented Jul 20, 2016

Bot Please so your job here ;)

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants